From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id 7AEABC54EBD for ; Fri, 6 Jan 2023 17:44:57 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S234213AbjAFRo4 (ORCPT ); Fri, 6 Jan 2023 12:44:56 -0500 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:39032 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S229448AbjAFRoy (ORCPT ); Fri, 6 Jan 2023 12:44:54 -0500 Received: from mailrelay5-1.pub.mailoutpod2-cph3.one.com (mailrelay5-1.pub.mailoutpod2-cph3.one.com [IPv6:2a02:2350:5:404::1]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id C949532257 for ; Fri, 6 Jan 2023 09:44:52 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=ravnborg.org; s=rsa2; h=in-reply-to:content-type:mime-version:references:message-id:subject:cc:to: from:date:from; bh=FSqXexJzCRVeHRIZREcKXEAPwBfY3fDmKI9BXOUKmLs=; b=TyFpN28itepy0w/qodgA7k58SxSGO2oVol439ZxYDGmDVyMPXI8eCAEmNR3GSNDDa3N5KR1pFTpqL 0fxVWS+IoZR8n2b0vFH0bUl9J7XjOGWprjTylXOM0vdPcR7j7hVg5bWy6UhFhTT/Yi0VgaD/xkrX2N I3DvWsZTAmFqBnDkU9eVNJ/S0MhaMpL5KVWVnSjrwlw9t1sEk5QHG0hpqlC4kkkRwoiQPHg6howi9L W7aEGiM30DK1V2/6Q6uHFAoxEW9mau9Jm83ZSWD/LExt2k2iqO0MCP6a1MYo5iIhnDdshOYfy7rhM9 VBjCjfF++NwMSmRf8BB+j9ccQj0NYcQ== DKIM-Signature: v=1; a=ed25519-sha256; c=relaxed/relaxed; d=ravnborg.org; s=ed2; h=in-reply-to:content-type:mime-version:references:message-id:subject:cc:to: from:date:from; bh=FSqXexJzCRVeHRIZREcKXEAPwBfY3fDmKI9BXOUKmLs=; b=VdqY98AJKtj0j1G6CDmNlGEHh0seMeKpXOOv835nCu+xHeTIwx+sgbs5s1jaaIFnx5HxD1+HlbnES eQQxSUrAw== X-HalOne-ID: d04ebfe6-8de9-11ed-9e86-7703b0afff57 Received: from ravnborg.org (2-105-2-98-cable.dk.customer.tdc.net [2.105.2.98]) by mailrelay5 (Halon) with ESMTPSA id d04ebfe6-8de9-11ed-9e86-7703b0afff57; Fri, 06 Jan 2023 17:44:50 +0000 (UTC) Date: Fri, 6 Jan 2023 18:44:49 +0100 From: Sam Ravnborg To: Stephen Kitt Cc: Lee Jones , Daniel Thompson , Jingoo Han , linux-fbdev@vger.kernel.org, Helge Deller , linux-kernel@vger.kernel.org, dri-devel@lists.freedesktop.org Subject: Re: [PATCH RESEND 2/4] backlight: arcxcnn: Use backlight helper Message-ID: References: <20230106164856.1453819-3-steve@sk2.org> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20230106164856.1453819-3-steve@sk2.org> Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Fri, Jan 06, 2023 at 05:48:53PM +0100, Stephen Kitt wrote: > Instead of retrieving the backlight brightness in struct > backlight_properties manually, and then checking whether the backlight > should be on at all, use backlight_get_brightness() which does all > this and insulates this from future changes. > > Signed-off-by: Stephen Kitt Reviewed-by: Sam Ravnborg > --- > drivers/video/backlight/arcxcnn_bl.c | 5 +---- > 1 file changed, 1 insertion(+), 4 deletions(-) > > diff --git a/drivers/video/backlight/arcxcnn_bl.c b/drivers/video/backlight/arcxcnn_bl.c > index 555b036643fb..e610d7a1d13d 100644 > --- a/drivers/video/backlight/arcxcnn_bl.c > +++ b/drivers/video/backlight/arcxcnn_bl.c > @@ -130,12 +130,9 @@ static int arcxcnn_set_brightness(struct arcxcnn *lp, u32 brightness) > static int arcxcnn_bl_update_status(struct backlight_device *bl) > { > struct arcxcnn *lp = bl_get_data(bl); > - u32 brightness = bl->props.brightness; > + u32 brightness = backlight_get_brightness(bl); > int ret; > > - if (bl->props.state & (BL_CORE_SUSPENDED | BL_CORE_FBBLANK)) > - brightness = 0; > - > ret = arcxcnn_set_brightness(lp, brightness); > if (ret) > return ret; > -- > 2.30.2