From: Jason Gunthorpe <jgg@ziepe.ca>
To: Alex Williamson <alex.williamson@redhat.com>
Cc: "Niklas Schnelle" <schnelle@linux.ibm.com>,
"Cornelia Huck" <cohuck@redhat.com>,
kvm@vger.kernel.org, linux-kernel@vger.kernel.org,
linux-s390@vger.kernel.org,
"Matthew Rosato" <mjrosato@linux.ibm.com>,
"Pierre Morel" <pmorel@linux.ibm.com>,
"Christian Bornträger" <borntraeger@linux.ibm.com>
Subject: Re: [PATCH v2 1/1] vfio/type1: Respect IOMMU reserved regions in vfio_test_domain_fgsp()
Date: Fri, 6 Jan 2023 14:03:42 -0400 [thread overview]
Message-ID: <Y7hifk0RHT3tlqqW@ziepe.ca> (raw)
In-Reply-To: <20230106102450.2e6c70bb.alex.williamson@redhat.com>
On Fri, Jan 06, 2023 at 10:24:50AM -0700, Alex Williamson wrote:
> > - ret = iommu_map(domain->domain, 0, page_to_phys(pages), PAGE_SIZE * 2,
> > - IOMMU_READ | IOMMU_WRITE | IOMMU_CACHE);
> > - if (!ret) {
> > - size_t unmapped = iommu_unmap(domain->domain, 0, PAGE_SIZE);
> > + list_for_each_entry(region, regions, list) {
> > + if (region->end - region->start < PAGE_SIZE * 2 ||
> > + region->start % (PAGE_SIZE*2))
>
> Maybe this falls into the noise, but we don't care if region->start is
> aligned to a double page, so long as we can map an aligned double page
> within the region. Maybe something like:
> dma_addr_t start = ALIGN(region->start, PAGE_SIZE * 2);
>
> if (start >= region->end || (region->end - start < PAGE_SIZE * 2))
> continue;
Yeah, that is more technically correct
Jason
next prev parent reply other threads:[~2023-01-06 18:03 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-01-04 15:42 [PATCH v2 0/1] vfio/type1: Fix vfio-pci pass-through of ISM devices Niklas Schnelle
2023-01-04 15:42 ` [PATCH v2 1/1] vfio/type1: Respect IOMMU reserved regions in vfio_test_domain_fgsp() Niklas Schnelle
2023-01-05 16:06 ` Matthew Rosato
2023-01-06 17:24 ` Alex Williamson
2023-01-06 18:03 ` Jason Gunthorpe [this message]
2023-01-09 8:49 ` Niklas Schnelle
2023-01-09 9:00 ` Niklas Schnelle
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=Y7hifk0RHT3tlqqW@ziepe.ca \
--to=jgg@ziepe.ca \
--cc=alex.williamson@redhat.com \
--cc=borntraeger@linux.ibm.com \
--cc=cohuck@redhat.com \
--cc=kvm@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-s390@vger.kernel.org \
--cc=mjrosato@linux.ibm.com \
--cc=pmorel@linux.ibm.com \
--cc=schnelle@linux.ibm.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox