From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id B7C98C54EBE for ; Sat, 7 Jan 2023 08:37:02 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S230210AbjAGIhB (ORCPT ); Sat, 7 Jan 2023 03:37:01 -0500 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:54316 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S230098AbjAGIg7 (ORCPT ); Sat, 7 Jan 2023 03:36:59 -0500 Received: from mail-wm1-x330.google.com (mail-wm1-x330.google.com [IPv6:2a00:1450:4864:20::330]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id A020D62E4; Sat, 7 Jan 2023 00:36:57 -0800 (PST) Received: by mail-wm1-x330.google.com with SMTP id m3so2571368wmq.0; Sat, 07 Jan 2023 00:36:57 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20210112; h=in-reply-to:content-disposition:mime-version:references:message-id :subject:cc:to:from:date:from:to:cc:subject:date:message-id:reply-to; bh=9Kpmp5ViMXQZaBwFWZ1zqfOIbWm4lMVj5MdpfVpHf2I=; b=neQVFbf4EoP+oScH8OC24LRifXnt+vY6/gyroJsaeg7+8njaUfvkAzQzZcikIwpYHb TJW7EhnLmpstDJbkKfIIQUyRnquhzoj5hfSd7kXrq2XXjKldHl/oUzwvZrz2fydTai8P DWj+nicLFA6CEV1Qyf8UnSFTMjhh+DNtPE4Am7BiPk7p2s0juXtRp2JgTrX8O3c3/Keo g8gS+nTrzRJSbxHrGfcCCGpefvS/UoX3W1UYWJOtGx0LYKa9oFfbiepYx83wCs+8zViT eu6+smHsrGLdKdYZhwIxTmi1gQMI09DR+kYNzgQS7lOMrXS/EUCJ7jXhlewyEadsUDTU kbLQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=in-reply-to:content-disposition:mime-version:references:message-id :subject:cc:to:from:date:x-gm-message-state:from:to:cc:subject:date :message-id:reply-to; bh=9Kpmp5ViMXQZaBwFWZ1zqfOIbWm4lMVj5MdpfVpHf2I=; b=WfalXUyW4aeVCQg5PmpBijlod1UVX1DvBrvTDbtDG3R1YVpjpXHIG02vpzEuwbJHCY H65rzq6ACw6q5nF/i5HsQIVINYYm9Tfv5hP1HqQ8EHNf13dXo98biqrRRlB2iqA3mBpg vyiYQMUojGAtWs/jiduUaCvuTB+jsFEmjUVzJeWulY3LKurAqsUjc8JxqpEeX5sK3b7R 2G/6fki0EhhhPrWZJK3nIbTKicFdfQOvnHA4YUKv8LYhvIwCGK76+kuydtWbFmtFxsn5 GJzjV/7h4Q10rtfOOteM2b0Y0JCg1A+SyT+iwTCFRMjgeCq8D0JuHbg9gHGXq6IBYe7O VFWA== X-Gm-Message-State: AFqh2kpXvO2VozFxjp20E4ERLGCtEE+ULYRYX14q3uEPlz/i4OawUmLf C1LFnTepcY41HC6mT1ktuBg= X-Google-Smtp-Source: AMrXdXu+1UTGj9TxEIS1UXUF4nUQzygqcPHzx2yn1IcguqEi74bhpVFdZDeTbsu7IAO+wDxMcH96jA== X-Received: by 2002:a05:600c:22ca:b0:3d1:ebdf:d586 with SMTP id 10-20020a05600c22ca00b003d1ebdfd586mr41267755wmg.29.1673080616209; Sat, 07 Jan 2023 00:36:56 -0800 (PST) Received: from localhost ([102.36.222.112]) by smtp.gmail.com with ESMTPSA id bh13-20020a05600c3d0d00b003d358beab9dsm4419716wmb.47.2023.01.07.00.36.54 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Sat, 07 Jan 2023 00:36:55 -0800 (PST) Date: Sat, 7 Jan 2023 11:36:51 +0300 From: Dan Carpenter To: Luis Chamberlain Cc: Tejun Heo , Jens Axboe , Christoph Hellwig , linux-block@vger.kernel.org, linux-kernel@vger.kernel.org Subject: Re: [PATCH block/for-6.2-fixes] block: Drop spurious might_sleep() from blk_put_queue() Message-ID: References: <9ac3390c-055b-546c-f1f4-68350dfe04f8@kernel.dk> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Fri, Jan 06, 2023 at 12:45:12PM -0800, Luis Chamberlain wrote: > > Signed-off-by: Tejun Heo > > Reported-by: Dan Carpenter > > Link: https://lkml.kernel.org/r/Y7g3L6fntnTtOm63@kili > > Cc: Christoph Hellwig > > Cc: Luis Chamberlain > > Fixes: e8c7d14ac6c3 ("block: revert back to synchronous request_queue removal") # v5.9+ > > *tons* has changed since e8c7d14ac6c3 and so the bots might think that > *if* this patch is applied upstream it is justified for older kernels > and I don't think that's yet been verified and doubt it. If you enable the correct debug option then the might_sleep() causes a stack trace. Eventually syzbot will find it. I would backport it. regards, dan carpenter