From: Wolfram Sang <wsa@kernel.org>
To: Hanna Hawa <hhhawa@amazon.com>
Cc: jarkko.nikula@linux.intel.com, andriy.shevchenko@linux.intel.com,
mika.westerberg@linux.intel.com, jsd@semihalf.com,
linus.walleij@linaro.org, ben-linux@fluff.org,
linux-i2c@vger.kernel.org, linux-kernel@vger.kernel.org,
dwmw@amazon.co.uk, benh@amazon.com, ronenk@amazon.com,
talel@amazon.com, jonnyc@amazon.com, hanochu@amazon.com,
farbere@amazon.com, itamark@amazon.com, lareine@amazon.com
Subject: Re: [PATCH v5 1/1] i2c: designware: use casting of u64 in clock multiplication to avoid overflow
Date: Mon, 9 Jan 2023 13:07:49 +0100 [thread overview]
Message-ID: <Y7wDlaOX8f9LhkCI@ninjato> (raw)
In-Reply-To: <20221221195900.23276-1-hhhawa@amazon.com>
[-- Attachment #1: Type: text/plain, Size: 771 bytes --]
On Wed, Dec 21, 2022 at 07:59:00PM +0000, Hanna Hawa wrote:
> From: Lareine Khawaly <lareine@amazon.com>
>
> In functions i2c_dw_scl_lcnt() and i2c_dw_scl_hcnt() may have overflow
> by depending on the values of the given parameters including the ic_clk.
> For example in our use case where ic_clk is larger than one million,
> multiplication of ic_clk * 4700 will result in 32 bit overflow.
>
> Add cast of u64 to the calculation to avoid multiplication overflow, and
> use the corresponding define for divide.
>
> Fixes: 2373f6b9744d ("i2c-designware: split of i2c-designware.c into core and bus specific parts")
> Signed-off-by: Lareine Khawaly <lareine@amazon.com>
> Signed-off-by: Hanna Hawa <hhhawa@amazon.com>
Applied to for-current, thanks!
[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 833 bytes --]
prev parent reply other threads:[~2023-01-09 12:08 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-12-21 19:59 [PATCH v5 1/1] i2c: designware: use casting of u64 in clock multiplication to avoid overflow Hanna Hawa
2022-12-21 20:07 ` Andy Shevchenko
2022-12-22 15:14 ` Jarkko Nikula
2023-01-09 12:07 ` Wolfram Sang [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=Y7wDlaOX8f9LhkCI@ninjato \
--to=wsa@kernel.org \
--cc=andriy.shevchenko@linux.intel.com \
--cc=ben-linux@fluff.org \
--cc=benh@amazon.com \
--cc=dwmw@amazon.co.uk \
--cc=farbere@amazon.com \
--cc=hanochu@amazon.com \
--cc=hhhawa@amazon.com \
--cc=itamark@amazon.com \
--cc=jarkko.nikula@linux.intel.com \
--cc=jonnyc@amazon.com \
--cc=jsd@semihalf.com \
--cc=lareine@amazon.com \
--cc=linus.walleij@linaro.org \
--cc=linux-i2c@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=mika.westerberg@linux.intel.com \
--cc=ronenk@amazon.com \
--cc=talel@amazon.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox