From: Ingo Molnar <mingo@kernel.org>
To: Alexander Lobakin <alexandr.lobakin@intel.com>
Cc: Thomas Gleixner <tglx@linutronix.de>,
Ingo Molnar <mingo@redhat.com>, Borislav Petkov <bp@alien8.de>,
Dave Hansen <dave.hansen@linux.intel.com>,
Jiri Slaby <jirislaby@kernel.org>,
"H. Peter Anvin" <hpa@zytor.com>,
"Peter Zijlstra (Intel)" <peterz@infradead.org>,
Tony Luck <tony.luck@intel.com>,
Kees Cook <keescook@chromium.org>,
Masahiro Yamada <masahiroy@kernel.org>,
x86@kernel.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH v3 0/2] x86/boot: fix relying on link order
Date: Mon, 9 Jan 2023 18:23:44 +0100 [thread overview]
Message-ID: <Y7xNoPT9aC/nIbnM@gmail.com> (raw)
In-Reply-To: <20230109170403.4117105-1-alexandr.lobakin@intel.com>
* Alexander Lobakin <alexandr.lobakin@intel.com> wrote:
> Currently, the x86 decompressor code expects the kernel entry point to be
> exactly at the beginning of the kernel image. It's always been true, but
> is hacky in multiple ways: special .head.text section and linking certain
> object files first to have them at the beginning.
> Make the code independent from the link order and then kill the latter.
> The former is to be resolved a bit later.
>
> I didn't put any "Fixes:" tag since it's not linear. The lines changed
> with 0001 came from the initial x86 KASLR series, but that unconditional
> jump to the kernel beginning already was there. It goes at least from the
> set that brought relocatable kernel support to x86, but this is quite
> prehistoric already and might not look really relatable.
>
> Alexander Lobakin (2):
> x86/boot: robustify calling startup_{32,64}() from the decompressor
> code
> scripts/head-object-list: remove x86 from the list
>
> arch/x86/boot/compressed/head_32.S | 2 +-
> arch/x86/boot/compressed/head_64.S | 2 +-
> arch/x86/boot/compressed/misc.c | 18 +++++++++++-------
> scripts/head-object-list.txt | 6 ------
> 4 files changed, 13 insertions(+), 15 deletions(-)
That's a really nice fix/robustification improvement - I've applied your
series to tip:x86/boot and will push it out after some testing.
Thanks,
Ingo
prev parent reply other threads:[~2023-01-09 17:23 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-01-09 17:04 [PATCH v3 0/2] x86/boot: fix relying on link order Alexander Lobakin
2023-01-09 17:04 ` [PATCH v3 1/2] x86/boot: robustify calling startup_{32,64}() from the decompressor code Alexander Lobakin
2023-01-09 18:22 ` [tip: x86/boot] x86/boot: Robustify " tip-bot2 for Alexander Lobakin
2023-01-09 17:04 ` [PATCH v3 2/2] scripts/head-object-list: remove x86 from the list Alexander Lobakin
2023-01-09 18:22 ` [tip: x86/boot] scripts/head-object-list: Remove " tip-bot2 for Alexander Lobakin
2023-01-09 17:23 ` Ingo Molnar [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=Y7xNoPT9aC/nIbnM@gmail.com \
--to=mingo@kernel.org \
--cc=alexandr.lobakin@intel.com \
--cc=bp@alien8.de \
--cc=dave.hansen@linux.intel.com \
--cc=hpa@zytor.com \
--cc=jirislaby@kernel.org \
--cc=keescook@chromium.org \
--cc=linux-kernel@vger.kernel.org \
--cc=masahiroy@kernel.org \
--cc=mingo@redhat.com \
--cc=peterz@infradead.org \
--cc=tglx@linutronix.de \
--cc=tony.luck@intel.com \
--cc=x86@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox