From: Andy Shevchenko <andriy.shevchenko@linux.intel.com>
To: Jonathan Cameron <jic23@kernel.org>
Cc: "Jonathan Cameron" <Jonathan.Cameron@huawei.com>,
"Nuno Sá" <nuno.sa@analog.com>,
linux-arm-msm@vger.kernel.org, linux-iio@vger.kernel.org,
linux-kernel@vger.kernel.org, "Andy Gross" <agross@kernel.org>,
"Bjorn Andersson" <andersson@kernel.org>,
"Konrad Dybcio" <konrad.dybcio@linaro.org>,
"Lars-Peter Clausen" <lars@metafoo.de>,
"Marijn Suijten" <marijn.suijten@somainline.org>,
"Dmitry Baryshkov" <dmitry.baryshkov@linaro.org>
Subject: Re: [PATCH v2 1/1] iio: adc: qcom-spmi-adc5: Fix the channel name
Date: Mon, 23 Jan 2023 14:02:51 +0200 [thread overview]
Message-ID: <Y853a5jr4rfrDHfd@smile.fi.intel.com> (raw)
In-Reply-To: <20230122172441.4f8d75f5@jic23-huawei>
On Sun, Jan 22, 2023 at 05:24:41PM +0000, Jonathan Cameron wrote:
> On Wed, 18 Jan 2023 12:06:23 +0200
> Andy Shevchenko <andriy.shevchenko@linux.intel.com> wrote:
>
> > The node name can contain an address part which is unused
> > by the driver. Moreover, this string is propagated into
> > the userspace label, sysfs filenames *and breaking ABI*.
> >
> > Cut the address part out before assigning the channel name.
> >
> > Fixes: 4f47a236a23d ("iio: adc: qcom-spmi-adc5: convert to device properties")
> > Reported-by: Marijn Suijten <marijn.suijten@somainline.org>
> > Signed-off-by: Andy Shevchenko <andriy.shevchenko@linux.intel.com>
>
> LGTM, but given it will have ABI impact, I'd like to hear from
> Andy, Bjorn or Konrad as maintainers and /or Dmitry as someone
> who has touched this driver fairly recently.
Hmm... But this is to fix the ABI breakage. It means that the previous series
by Nuno had broken it.
> Mostly I want to be sure they know this exists before it causes surprise.
--
With Best Regards,
Andy Shevchenko
next prev parent reply other threads:[~2023-01-23 12:03 UTC|newest]
Thread overview: 16+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-01-18 10:06 [PATCH v2 1/1] iio: adc: qcom-spmi-adc5: Fix the channel name Andy Shevchenko
2023-01-18 12:35 ` Marijn Suijten
2023-01-18 13:22 ` Andy Shevchenko
2023-01-18 14:04 ` Marijn Suijten
2023-01-18 14:29 ` Andy Shevchenko
2023-01-18 15:21 ` Marijn Suijten
2023-01-18 15:57 ` Andy Shevchenko
2023-01-22 17:24 ` Jonathan Cameron
2023-01-23 12:02 ` Andy Shevchenko [this message]
2023-01-23 19:30 ` Jonathan Cameron
2023-01-23 16:35 ` Konrad Dybcio
2023-01-23 17:01 ` Marijn Suijten
2023-01-23 17:04 ` Konrad Dybcio
2023-01-23 23:12 ` Doug Anderson
2023-01-25 19:39 ` Matthias Kaehlcke
2023-01-28 15:34 ` Jonathan Cameron
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=Y853a5jr4rfrDHfd@smile.fi.intel.com \
--to=andriy.shevchenko@linux.intel.com \
--cc=Jonathan.Cameron@huawei.com \
--cc=agross@kernel.org \
--cc=andersson@kernel.org \
--cc=dmitry.baryshkov@linaro.org \
--cc=jic23@kernel.org \
--cc=konrad.dybcio@linaro.org \
--cc=lars@metafoo.de \
--cc=linux-arm-msm@vger.kernel.org \
--cc=linux-iio@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=marijn.suijten@somainline.org \
--cc=nuno.sa@analog.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox