Re: [PATCH] drm/bridge: panel: Set orientation on panel_bridge connector

Sam Ravnborg
2023-01-21T08:57:27Z

Hi John/Douglas.

On Fri, Jan 20, 2023 at 01:44:38PM -0800, Doug Anderson wrote:
> Hi,
>
> On Fri, Jan 20, 2023 at 3:43 AM John Keeping <john@metanate.com> wrote:
> >
> > Commit 15b9ca1641f0 ("drm: Config orientation property if panel provides
> > it") added a helper to set the panel panel orientation early but only
> > connected this for drm_bridge_connector, which constructs a panel bridge
> > with DRM_BRIDGE_ATTACH_NO_CONNECTOR and creates the connector itself.
> >
> > When the DRM_BRIDGE_ATTACH_NO_CONNECTOR flag is not specified and the
> > panel_bridge creates its own connector the orientation is not set unless
> > the panel does it in .get_modes which is too late and leads to a warning
> > splat from __drm_mode_object_add() because the device is already
> > registered.
> >
> > Call the necessary function to set add the orientation property when the
> > connector is created so that it is available before the device is
> > registered.
>
> I have no huge objection to your patch and it looks OK to me. That
> being said, my understanding is that:
>
> 1. DRM_BRIDGE_ATTACH_NO_CONNECTOR is "the future" and not using the
> flag is "deprecated".
Correct.
Could we take a look at how much is required to move the relevant driver
to use DRM_BRIDGE_ATTACH_NO_CONNECTOR?

If this is too much work now we may land this simple patch, but the
preference is to move all drivers to the new bridge handling and thus
asking display drivers to create the connector.

What display driver are we dealing with here?

Sam