* [PATCH] media: imx: imx-media-fim: Replace macro icap_enabled() with function
@ 2023-01-23 19:17 Brent Pappas
2023-01-23 21:51 ` Marco Felsch
0 siblings, 1 reply; 3+ messages in thread
From: Brent Pappas @ 2023-01-23 19:17 UTC (permalink / raw)
To: slongerbeam
Cc: p.zabel, mchehab, gregkh, shawnguo, s.hauer, kernel, festevam,
linux-imx, linux-media, linux-staging, linux-arm-kernel,
linux-kernel, Brent Pappas
Replace the macro icap_enabled() with a static function to comply
with Linux coding style standards.
Signed-off-by: Brent Pappas <bpappas@pappasbrent.com>
---
drivers/staging/media/imx/imx-media-fim.c | 5 ++++-
1 file changed, 4 insertions(+), 1 deletion(-)
diff --git a/drivers/staging/media/imx/imx-media-fim.c b/drivers/staging/media/imx/imx-media-fim.c
index fb6590dcfc36..ccb35d098a19 100644
--- a/drivers/staging/media/imx/imx-media-fim.c
+++ b/drivers/staging/media/imx/imx-media-fim.c
@@ -68,7 +68,10 @@ struct imx_media_fim {
bool stream_on;
};
-#define icap_enabled(fim) ((fim)->icap_flags != IRQ_TYPE_NONE)
+static bool icap_enabled(struct imx_media_fim *fim)
+{
+ return fim->icap_flags != IRQ_TYPE_NONE;
+}
static void update_fim_nominal(struct imx_media_fim *fim,
const struct v4l2_fract *fi)
--
2.34.1
^ permalink raw reply related [flat|nested] 3+ messages in thread* Re: [PATCH] media: imx: imx-media-fim: Replace macro icap_enabled() with function
2023-01-23 19:17 [PATCH] media: imx: imx-media-fim: Replace macro icap_enabled() with function Brent Pappas
@ 2023-01-23 21:51 ` Marco Felsch
2023-01-24 4:18 ` Dan Carpenter
0 siblings, 1 reply; 3+ messages in thread
From: Marco Felsch @ 2023-01-23 21:51 UTC (permalink / raw)
To: Brent Pappas
Cc: slongerbeam, festevam, p.zabel, gregkh, s.hauer, linux-staging,
linux-kernel, linux-imx, kernel, mchehab, shawnguo,
linux-arm-kernel, linux-media
Hi,
thank you for the patch.
On 23-01-23, Brent Pappas wrote:
> Replace the macro icap_enabled() with a static function to comply
> with Linux coding style standards.
>
> Signed-off-by: Brent Pappas <bpappas@pappasbrent.com>
> ---
> drivers/staging/media/imx/imx-media-fim.c | 5 ++++-
> 1 file changed, 4 insertions(+), 1 deletion(-)
>
> diff --git a/drivers/staging/media/imx/imx-media-fim.c b/drivers/staging/media/imx/imx-media-fim.c
> index fb6590dcfc36..ccb35d098a19 100644
> --- a/drivers/staging/media/imx/imx-media-fim.c
> +++ b/drivers/staging/media/imx/imx-media-fim.c
> @@ -68,7 +68,10 @@ struct imx_media_fim {
> bool stream_on;
> };
>
> -#define icap_enabled(fim) ((fim)->icap_flags != IRQ_TYPE_NONE)
> +static bool icap_enabled(struct imx_media_fim *fim)
> +{
> + return fim->icap_flags != IRQ_TYPE_NONE;
> +}
Nit: I would make it inline but recent compiler may do the job for us.
Reviewed-by: Marco Felsch <m.felsch@pengutronix.de>
Regards,
Marco
> static void update_fim_nominal(struct imx_media_fim *fim,
> const struct v4l2_fract *fi)
> --
> 2.34.1
>
>
>
^ permalink raw reply [flat|nested] 3+ messages in thread* Re: [PATCH] media: imx: imx-media-fim: Replace macro icap_enabled() with function
2023-01-23 21:51 ` Marco Felsch
@ 2023-01-24 4:18 ` Dan Carpenter
0 siblings, 0 replies; 3+ messages in thread
From: Dan Carpenter @ 2023-01-24 4:18 UTC (permalink / raw)
To: Marco Felsch
Cc: Brent Pappas, slongerbeam, festevam, p.zabel, gregkh, s.hauer,
linux-staging, linux-kernel, linux-imx, kernel, mchehab, shawnguo,
linux-arm-kernel, linux-media
On Mon, Jan 23, 2023 at 10:51:05PM +0100, Marco Felsch wrote:
> > -#define icap_enabled(fim) ((fim)->icap_flags != IRQ_TYPE_NONE)
> > +static bool icap_enabled(struct imx_media_fim *fim)
> > +{
> > + return fim->icap_flags != IRQ_TYPE_NONE;
> > +}
>
> Nit: I would make it inline but recent compiler may do the job for us.
>
Yeah. These days we tend to not make things inline.
regards,
dan carpenter
> Reviewed-by: Marco Felsch <m.felsch@pengutronix.de>
>
> Regards,
> Marco
^ permalink raw reply [flat|nested] 3+ messages in thread
end of thread, other threads:[~2023-01-24 4:18 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2023-01-23 19:17 [PATCH] media: imx: imx-media-fim: Replace macro icap_enabled() with function Brent Pappas
2023-01-23 21:51 ` Marco Felsch
2023-01-24 4:18 ` Dan Carpenter
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox