Re: [PATCH] media: imx: imx-media-fim: Replace macro icap_enabled() with function

Dan Carpenter
2023-01-24T04:18:59Z

On Mon, Jan 23, 2023 at 10:51:05PM +0100, Marco Felsch wrote:
> > -#define icap_enabled(fim) ((fim)->icap_flags != IRQ_TYPE_NONE)
> > +static bool icap_enabled(struct imx_media_fim *fim)
> > +{
> > + return fim->icap_flags != IRQ_TYPE_NONE;
> > +}
>
> Nit: I would make it inline but recent compiler may do the job for us.
>

Yeah. These days we tend to not make things inline.

regards,
dan carpenter

> Reviewed-by: Marco Felsch <m.felsch@pengutronix.de>
>
> Regards,
> Marco