From: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
To: "Isaac J. Manjarres" <isaacmanjarres@google.com>
Cc: "Rafael J. Wysocki" <rafael@kernel.org>,
Marek Szyprowski <m.szyprowski@samsung.com>,
Tomeu Vizoso <tomeu.vizoso@collabora.com>,
Russell King <rmk+kernel@arm.linux.org.uk>,
Ulf Hansson <ulf.hansson@linaro.org>,
stable@vger.kernel.org, Saravana Kannan <saravanak@google.com>,
kernel-team@android.com, linux-kernel@vger.kernel.org
Subject: Re: [PATCH stable-4.14] driver core: Fix bus_type.match() error handling in __driver_attach()
Date: Thu, 12 Jan 2023 13:52:28 +0100 [thread overview]
Message-ID: <Y8ACjLc272RM0vSP@kroah.com> (raw)
In-Reply-To: <20230110021536.1347134-1-isaacmanjarres@google.com>
On Mon, Jan 09, 2023 at 06:15:36PM -0800, Isaac J. Manjarres wrote:
> commit 27c0d217340e47ec995557f61423ef415afba987 upstream.
>
> When a driver registers with a bus, it will attempt to match with every
> device on the bus through the __driver_attach() function. Currently, if
> the bus_type.match() function encounters an error that is not
> -EPROBE_DEFER, __driver_attach() will return a negative error code, which
> causes the driver registration logic to stop trying to match with the
> remaining devices on the bus.
>
> This behavior is not correct; a failure while matching a driver to a
> device does not mean that the driver won't be able to match and bind
> with other devices on the bus. Update the logic in __driver_attach()
> to reflect this.
>
> Fixes: 656b8035b0ee ("ARM: 8524/1: driver cohandle -EPROBE_DEFER from bus_type.match()")
> Cc: stable@vger.kernel.org
> Cc: Saravana Kannan <saravanak@google.com>
> Signed-off-by: Isaac J. Manjarres <isaacmanjarres@google.com>
> ---
> drivers/base/dd.c | 8 ++++++--
> 1 file changed, 6 insertions(+), 2 deletions(-)
All now queued up, thanks.
greg k-h
prev parent reply other threads:[~2023-01-12 12:52 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-01-10 2:15 [PATCH stable-4.14] driver core: Fix bus_type.match() error handling in __driver_attach() Isaac J. Manjarres
2023-01-12 12:52 ` Greg Kroah-Hartman [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=Y8ACjLc272RM0vSP@kroah.com \
--to=gregkh@linuxfoundation.org \
--cc=isaacmanjarres@google.com \
--cc=kernel-team@android.com \
--cc=linux-kernel@vger.kernel.org \
--cc=m.szyprowski@samsung.com \
--cc=rafael@kernel.org \
--cc=rmk+kernel@arm.linux.org.uk \
--cc=saravanak@google.com \
--cc=stable@vger.kernel.org \
--cc=tomeu.vizoso@collabora.com \
--cc=ulf.hansson@linaro.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox