From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id 1C8E5C61DB3 for ; Fri, 13 Jan 2023 07:57:51 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S239769AbjAMH5q (ORCPT ); Fri, 13 Jan 2023 02:57:46 -0500 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:44874 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S234352AbjAMH5f (ORCPT ); Fri, 13 Jan 2023 02:57:35 -0500 Received: from ams.source.kernel.org (ams.source.kernel.org [IPv6:2604:1380:4601:e00::1]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 31DE843E52; Thu, 12 Jan 2023 23:57:33 -0800 (PST) Received: from smtp.kernel.org (relay.kernel.org [52.25.139.140]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by ams.source.kernel.org (Postfix) with ESMTPS id 1EA69B82082; Fri, 13 Jan 2023 07:57:32 +0000 (UTC) Received: by smtp.kernel.org (Postfix) with ESMTPSA id BD6BFC433EF; Fri, 13 Jan 2023 07:57:30 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1673596650; bh=juHaHBh9x6cKYqj2AXbOmzUdy7K0OtqpTmvN7ThLO/Y=; h=Date:From:To:Cc:Subject:References:In-Reply-To:From; b=OocD74CLJ9vF7YkOzEO6xQAASzo57PlPsnuYNXBkjvKhl8SaAbloH4/LZ73o++jtV pd9Ft8oF+/jKLNUT1D6VODVjvFG5RpznhV/8E1oN/1L5/81si/qOVDfq0mJTjVk3kw Jv6YhxatEAh3SSrNgND5uL+Ez3bX5KWcm+NdW4XbeaGbxXtt/eDvMwDmPxaF0SJ0+5 Bkk330NhUZ7kAOQiqH2NHYPxWYAtFuSolzLv3WVoV5hfp3bGSrSgAEo+lnf7UPUCzj W5qA5NmQLVkL9HO1KwYWDO3/b5W12m5HutAVoPxphGWQQFHLjFoylGY5uM58AmPJ8D hxxwF+0iy3xgg== Received: from johan by xi.lan with local (Exim 4.94.2) (envelope-from ) id 1pGEwV-00066j-HK; Fri, 13 Jan 2023 08:57:40 +0100 Date: Fri, 13 Jan 2023 08:57:39 +0100 From: Johan Hovold To: Stephen Boyd Cc: stable@vger.kernel.org, Johan Hovold , linux-kernel@vger.kernel.org, patches@lists.linux.dev, Vinod Koul Subject: Re: [PATCH 5.15.y 2/4] phy: qcom-qmp-combo: fix memleak on probe deferral Message-ID: References: <20230113005405.3992011-1-swboyd@chromium.org> <20230113005405.3992011-3-swboyd@chromium.org> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20230113005405.3992011-3-swboyd@chromium.org> Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Thu, Jan 12, 2023 at 04:54:03PM -0800, Stephen Boyd wrote: > From: Johan Hovold > > commit 2de8a325b1084330ae500380cc27edc39f488c30 upstream. > > Switch to using the device-managed of_iomap helper to avoid leaking > memory on probe deferral and driver unbind. > > Note that this helper checks for already reserved regions and may fail > if there are multiple devices claiming the same memory. This bit turned out to catch some buggy bindings and dts, so if you want to backport this one then the corresponding fixes for that would be needed as well. That includes a5d6b1ac56cb ("phy: qcom-qmp-usb: fix memleak on probe deferral") and some dts fixes which likely already have been backported. It may even be preferred to keep to just skip this patch and keep those small memory leaks on probe deferral to not risk any regressions in stable. > Fixes: e78f3d15e115 ("phy: qcom-qmp: new qmp phy driver for qcom-chipsets") > Signed-off-by: Johan Hovold > Link: https://lore.kernel.org/r/20220916102340.11520-5-johan+linaro@kernel.org > Signed-off-by: Vinod Koul > Signed-off-by: Stephen Boyd Johan