From: Jason Gunthorpe <jgg@ziepe.ca>
To: Joerg Roedel <joro@8bytes.org>
Cc: Lu Baolu <baolu.lu@linux.intel.com>,
Will Deacon <will@kernel.org>,
Robin Murphy <robin.murphy@arm.com>,
Vasant Hegde <vasant.hegde@amd.com>,
Chunyan Zhang <zhang.lyra@gmail.com>,
Sven Peter <sven@svenpeter.dev>,
iommu@lists.linux.dev, linux-kernel@vger.kernel.org,
Joerg Roedel <jroedel@suse.de>
Subject: Re: [PATCH] iommu/ipmmu-vmsa: Remove ipmmu_utlb_disable()
Date: Fri, 13 Jan 2023 15:12:21 -0400 [thread overview]
Message-ID: <Y8GtFcNq2jugBpI3@ziepe.ca> (raw)
In-Reply-To: <20230113185640.8050-1-joro@8bytes.org>
On Fri, Jan 13, 2023 at 07:56:40PM +0100, Joerg Roedel wrote:
> From: Joerg Roedel <jroedel@suse.de>
>
> The function is unused after commit 1b932ceddd19 ("iommu:
> Remove detach_dev callbacks") and so compilation fails with
>
> drivers/iommu/ipmmu-vmsa.c:305:13: error: ‘ipmmu_utlb_disable’ defined but not used [-Werror=unused-function]
> 305 | static void ipmmu_utlb_disable(struct ipmmu_vmsa_domain *domain,
> | ^~~~~~~~~~~~~~~~~~
>
> Remove the function to fix the compile error.
>
> Fixes: 1b932ceddd19 ("iommu: Remove detach_dev callbacks")
> Signed-off-by: Joerg Roedel <jroedel@suse.de>
> ---
> drivers/iommu/ipmmu-vmsa.c | 12 ------------
> 1 file changed, 12 deletions(-)
I'm surprised the 0-day bot didn't notice?
Reviewed-by: Jason Gunthorpe <jgg@nvidia.com>
Jason
next prev parent reply other threads:[~2023-01-13 19:12 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-01-13 18:56 [PATCH] iommu/ipmmu-vmsa: Remove ipmmu_utlb_disable() Joerg Roedel
2023-01-13 19:12 ` Jason Gunthorpe [this message]
2023-01-13 19:25 ` Joerg Roedel
2023-01-13 19:45 ` Jason Gunthorpe
2023-01-13 21:29 ` Joerg Roedel
2023-01-14 6:48 ` Baolu Lu
2023-01-14 6:44 ` Baolu Lu
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=Y8GtFcNq2jugBpI3@ziepe.ca \
--to=jgg@ziepe.ca \
--cc=baolu.lu@linux.intel.com \
--cc=iommu@lists.linux.dev \
--cc=joro@8bytes.org \
--cc=jroedel@suse.de \
--cc=linux-kernel@vger.kernel.org \
--cc=robin.murphy@arm.com \
--cc=sven@svenpeter.dev \
--cc=vasant.hegde@amd.com \
--cc=will@kernel.org \
--cc=zhang.lyra@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox