Re: [PATCH v1] wireless/at76c50x-usb.c : Use devm_kmalloc replaces kmalloc

Leon Romanovsky
2023-01-15T12:13:56Z

On Fri, Jan 13, 2023 at 06:12:31AM -0800, Lizhe wrote:
> use devm_kmalloc replaces kmalloc

No, it is not.

>
> Signed-off-by: Lizhe <sensor1010@163.com>
> ---
> drivers/net/wireless/atmel/at76c50x-usb.c | 3 +--
> 1 file changed, 1 insertion(+), 2 deletions(-)
>
> diff --git a/drivers/net/wireless/atmel/at76c50x-usb.c b/drivers/net/wireless/atmel/at76c50x-usb.c
> index 009bca34ece3..f486ddb83d46 100644
> --- a/drivers/net/wireless/atmel/at76c50x-usb.c
> +++ b/drivers/net/wireless/atmel/at76c50x-usb.c
> @@ -2444,7 +2444,7 @@ static int at76_probe(struct usb_interface *interface,
>
> udev = usb_get_dev(interface_to_usbdev(interface));
>
> - fwv = kmalloc(sizeof(*fwv), GFP_KERNEL);
> + fwv = devm_kmalloc(sizeof(*fwv), GFP_KERNEL);
> if (!fwv) {
> ret = -ENOMEM;
> goto exit;
> @@ -2535,7 +2535,6 @@ static int at76_probe(struct usb_interface *interface,
> at76_delete_device(priv);
>
> exit:
> - kfree(fwv);
> if (ret < 0)
> usb_put_dev(udev);
> return ret;
> --
> 2.17.1
>