From: Johan Hovold <johan@kernel.org>
To: Daniele Palmas <dnlplm@gmail.com>
Cc: Johan Hovold <johan+linaro@kernel.org>,
Bjorn Andersson <andersson@kernel.org>,
Catalin Marinas <catalin.marinas@arm.com>,
Will Deacon <will@kernel.org>,
Manivannan Sadhasivam <manivannan.sadhasivam@linaro.org>,
Abel Vesa <abel.vesa@linaro.org>,
linux-arm-msm@vger.kernel.org,
linux-arm-kernel@lists.infradead.org,
linux-kernel@vger.kernel.org
Subject: Re: [PATCH] arm64: defconfig: enable Qualcomm PCIe modem drivers
Date: Sun, 15 Jan 2023 18:42:00 +0100 [thread overview]
Message-ID: <Y8Q66ClSIcww0GWq@hovoldconsulting.com> (raw)
In-Reply-To: <CAGRyCJHcbc3kad=8ugpo+hF9TGQZv2akzrYXa175HwCM7kVb9w@mail.gmail.com>
On Sun, Jan 15, 2023 at 01:11:08PM +0100, Daniele Palmas wrote:
> Hello Johan,
>
> Il giorno sab 14 gen 2023 alle ore 17:23 Johan Hovold
> <johan+linaro@kernel.org> ha scritto:
> >
> > Enable the MHI PCI controller driver and MHI WWAN drivers for Qualcomm
> > based PCIe modems such as the ones found on the SC8280XP Compute
> > Reference Design (CRD) and Lenovo Thinkpad X13s.
> >
> > Signed-off-by: Johan Hovold <johan+linaro@kernel.org>
> > ---
> > diff --git a/arch/arm64/configs/defconfig b/arch/arm64/configs/defconfig
> > index 86aa3730a8b6..117b49f3f1c1 100644
> > --- a/arch/arm64/configs/defconfig
> > +++ b/arch/arm64/configs/defconfig
> > @@ -250,6 +250,7 @@ CONFIG_DEVTMPFS_MOUNT=y
> > CONFIG_FW_LOADER_USER_HELPER=y
> > CONFIG_HISILICON_LPC=y
> > CONFIG_TEGRA_ACONNECT=m
> > +CONFIG_MHI_BUS_PCI_GENERIC=m
> > CONFIG_ARM_SCMI_PROTOCOL=y
> > CONFIG_ARM_SCPI_PROTOCOL=y
> > CONFIG_RASPBERRYPI_FIRMWARE=y
> > @@ -405,6 +406,9 @@ CONFIG_MWIFIEX_SDIO=m
> > CONFIG_MWIFIEX_PCIE=m
> > CONFIG_WL18XX=m
> > CONFIG_WLCORE_SDIO=m
> > +CONFIG_WWAN=m
> > +CONFIG_MHI_WWAN_CTRL=m
> > +CONFIG_MHI_WWAN_MBIM=m
>
> wondering if it could make sense to also enable CONFIG_MHI_NET, since
> in mhi_pci_generic there are also modems bound to that driver and, if
> not enabled, those would show just the control device, but not the
> netdevice.
Yes, indeed, that's a good idea. I had it enabled in my local config but
didn't include it as it isn't needed for the two machines I'm currently
working on.
I'll send a v2. Thanks!
Johan
prev parent reply other threads:[~2023-01-15 17:42 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-01-14 16:22 [PATCH] arm64: defconfig: enable Qualcomm PCIe modem drivers Johan Hovold
2023-01-15 4:25 ` Manivannan Sadhasivam
2023-01-15 12:11 ` Daniele Palmas
2023-01-15 17:42 ` Johan Hovold [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=Y8Q66ClSIcww0GWq@hovoldconsulting.com \
--to=johan@kernel.org \
--cc=abel.vesa@linaro.org \
--cc=andersson@kernel.org \
--cc=catalin.marinas@arm.com \
--cc=dnlplm@gmail.com \
--cc=johan+linaro@kernel.org \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-arm-msm@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=manivannan.sadhasivam@linaro.org \
--cc=will@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox