* [PATCH] clk: qcom: Remove need for clk_ignore_unused on sc8280xp
@ 2023-01-13 4:10 Bjorn Andersson
2023-01-13 4:16 ` Konrad Dybcio
` (4 more replies)
0 siblings, 5 replies; 6+ messages in thread
From: Bjorn Andersson @ 2023-01-13 4:10 UTC (permalink / raw)
To: Bjorn Andersson, Konrad Dybcio, Michael Turquette, Stephen Boyd,
Abel Vesa
Cc: linux-arm-msm, linux-clk, linux-kernel
With the transition of disabling unused clocks at sync_state, rather
than late_initcall() it's now possible to drop clk_ignore_unused and
unused clock disabled once client drivers have probed. Do this on
SC8280XP.
Signed-off-by: Bjorn Andersson <quic_bjorande@quicinc.com>
---
drivers/clk/qcom/dispcc-sc8280xp.c | 1 +
drivers/clk/qcom/gcc-sc8280xp.c | 1 +
2 files changed, 2 insertions(+)
diff --git a/drivers/clk/qcom/dispcc-sc8280xp.c b/drivers/clk/qcom/dispcc-sc8280xp.c
index 167470beb369..c84a6481b879 100644
--- a/drivers/clk/qcom/dispcc-sc8280xp.c
+++ b/drivers/clk/qcom/dispcc-sc8280xp.c
@@ -3199,6 +3199,7 @@ static struct platform_driver disp_cc_sc8280xp_driver = {
.driver = {
.name = "disp_cc-sc8280xp",
.of_match_table = disp_cc_sc8280xp_match_table,
+ .sync_state = clk_sync_state_disable_unused,
},
};
diff --git a/drivers/clk/qcom/gcc-sc8280xp.c b/drivers/clk/qcom/gcc-sc8280xp.c
index b3198784e1c3..f4fdc5b9663c 100644
--- a/drivers/clk/qcom/gcc-sc8280xp.c
+++ b/drivers/clk/qcom/gcc-sc8280xp.c
@@ -7441,6 +7441,7 @@ static struct platform_driver gcc_sc8280xp_driver = {
.driver = {
.name = "gcc-sc8280xp",
.of_match_table = gcc_sc8280xp_match_table,
+ .sync_state = clk_sync_state_disable_unused,
},
};
--
2.37.3
^ permalink raw reply related [flat|nested] 6+ messages in thread
* Re: [PATCH] clk: qcom: Remove need for clk_ignore_unused on sc8280xp
2023-01-13 4:10 [PATCH] clk: qcom: Remove need for clk_ignore_unused on sc8280xp Bjorn Andersson
@ 2023-01-13 4:16 ` Konrad Dybcio
2023-01-13 20:14 ` Andrew Halaney
` (3 subsequent siblings)
4 siblings, 0 replies; 6+ messages in thread
From: Konrad Dybcio @ 2023-01-13 4:16 UTC (permalink / raw)
To: Bjorn Andersson, Bjorn Andersson, Michael Turquette, Stephen Boyd,
Abel Vesa
Cc: linux-arm-msm, linux-clk, linux-kernel
The subject could be more in the likes of "use disable_unused sync_state"..
On 13.01.2023 05:10, Bjorn Andersson wrote:
> With the transition of disabling unused clocks at sync_state, rather
> than late_initcall() it's now possible to drop clk_ignore_unused and
> unused clock disabled once client drivers have probed. Do this on
> SC8280XP.
>
> Signed-off-by: Bjorn Andersson <quic_bjorande@quicinc.com>
> ---
Acked-by: Konrad Dybcio <konrad.dybcio@linaro.org>
Konrad
> drivers/clk/qcom/dispcc-sc8280xp.c | 1 +
> drivers/clk/qcom/gcc-sc8280xp.c | 1 +
> 2 files changed, 2 insertions(+)
>
> diff --git a/drivers/clk/qcom/dispcc-sc8280xp.c b/drivers/clk/qcom/dispcc-sc8280xp.c
> index 167470beb369..c84a6481b879 100644
> --- a/drivers/clk/qcom/dispcc-sc8280xp.c
> +++ b/drivers/clk/qcom/dispcc-sc8280xp.c
> @@ -3199,6 +3199,7 @@ static struct platform_driver disp_cc_sc8280xp_driver = {
> .driver = {
> .name = "disp_cc-sc8280xp",
> .of_match_table = disp_cc_sc8280xp_match_table,
> + .sync_state = clk_sync_state_disable_unused,
> },
> };
>
> diff --git a/drivers/clk/qcom/gcc-sc8280xp.c b/drivers/clk/qcom/gcc-sc8280xp.c
> index b3198784e1c3..f4fdc5b9663c 100644
> --- a/drivers/clk/qcom/gcc-sc8280xp.c
> +++ b/drivers/clk/qcom/gcc-sc8280xp.c
> @@ -7441,6 +7441,7 @@ static struct platform_driver gcc_sc8280xp_driver = {
> .driver = {
> .name = "gcc-sc8280xp",
> .of_match_table = gcc_sc8280xp_match_table,
> + .sync_state = clk_sync_state_disable_unused,
> },
> };
>
^ permalink raw reply [flat|nested] 6+ messages in thread
* Re: [PATCH] clk: qcom: Remove need for clk_ignore_unused on sc8280xp
2023-01-13 4:10 [PATCH] clk: qcom: Remove need for clk_ignore_unused on sc8280xp Bjorn Andersson
2023-01-13 4:16 ` Konrad Dybcio
@ 2023-01-13 20:14 ` Andrew Halaney
2023-01-15 4:12 ` Manivannan Sadhasivam
` (2 subsequent siblings)
4 siblings, 0 replies; 6+ messages in thread
From: Andrew Halaney @ 2023-01-13 20:14 UTC (permalink / raw)
To: Bjorn Andersson
Cc: Bjorn Andersson, Konrad Dybcio, Michael Turquette, Stephen Boyd,
Abel Vesa, linux-arm-msm, linux-clk, linux-kernel
On Thu, Jan 12, 2023 at 08:10:38PM -0800, Bjorn Andersson wrote:
> With the transition of disabling unused clocks at sync_state, rather
> than late_initcall() it's now possible to drop clk_ignore_unused and
> unused clock disabled once client drivers have probed. Do this on
> SC8280XP.
>
> Signed-off-by: Bjorn Andersson <quic_bjorande@quicinc.com>
Tested-by: Andrew Halaney <ahalaney@redhat.com> # sc8280xp-lenovo-thinkpad-x13s
I've booted with this (and without clk_ignore_unused) a few times today
and have been working with on the machine without any apparent issues.
Thanks! It is nice to have to modify less of the kernel cli to boot.
> ---
> drivers/clk/qcom/dispcc-sc8280xp.c | 1 +
> drivers/clk/qcom/gcc-sc8280xp.c | 1 +
> 2 files changed, 2 insertions(+)
>
> diff --git a/drivers/clk/qcom/dispcc-sc8280xp.c b/drivers/clk/qcom/dispcc-sc8280xp.c
> index 167470beb369..c84a6481b879 100644
> --- a/drivers/clk/qcom/dispcc-sc8280xp.c
> +++ b/drivers/clk/qcom/dispcc-sc8280xp.c
> @@ -3199,6 +3199,7 @@ static struct platform_driver disp_cc_sc8280xp_driver = {
> .driver = {
> .name = "disp_cc-sc8280xp",
> .of_match_table = disp_cc_sc8280xp_match_table,
> + .sync_state = clk_sync_state_disable_unused,
> },
> };
>
> diff --git a/drivers/clk/qcom/gcc-sc8280xp.c b/drivers/clk/qcom/gcc-sc8280xp.c
> index b3198784e1c3..f4fdc5b9663c 100644
> --- a/drivers/clk/qcom/gcc-sc8280xp.c
> +++ b/drivers/clk/qcom/gcc-sc8280xp.c
> @@ -7441,6 +7441,7 @@ static struct platform_driver gcc_sc8280xp_driver = {
> .driver = {
> .name = "gcc-sc8280xp",
> .of_match_table = gcc_sc8280xp_match_table,
> + .sync_state = clk_sync_state_disable_unused,
> },
> };
>
> --
> 2.37.3
>
^ permalink raw reply [flat|nested] 6+ messages in thread
* Re: [PATCH] clk: qcom: Remove need for clk_ignore_unused on sc8280xp
2023-01-13 4:10 [PATCH] clk: qcom: Remove need for clk_ignore_unused on sc8280xp Bjorn Andersson
2023-01-13 4:16 ` Konrad Dybcio
2023-01-13 20:14 ` Andrew Halaney
@ 2023-01-15 4:12 ` Manivannan Sadhasivam
2023-01-15 16:11 ` Abel Vesa
2023-01-17 18:24 ` Bjorn Andersson
4 siblings, 0 replies; 6+ messages in thread
From: Manivannan Sadhasivam @ 2023-01-15 4:12 UTC (permalink / raw)
To: Bjorn Andersson
Cc: Bjorn Andersson, Konrad Dybcio, Michael Turquette, Stephen Boyd,
Abel Vesa, linux-arm-msm, linux-clk, linux-kernel
On Thu, Jan 12, 2023 at 08:10:38PM -0800, Bjorn Andersson wrote:
> With the transition of disabling unused clocks at sync_state, rather
> than late_initcall() it's now possible to drop clk_ignore_unused and
> unused clock disabled once client drivers have probed. Do this on
> SC8280XP.
>
> Signed-off-by: Bjorn Andersson <quic_bjorande@quicinc.com>
Reviewed-by: Manivannan Sadhasivam <manivannan.sadhasivam@linaro.org>
Thanks,
Mani
> ---
> drivers/clk/qcom/dispcc-sc8280xp.c | 1 +
> drivers/clk/qcom/gcc-sc8280xp.c | 1 +
> 2 files changed, 2 insertions(+)
>
> diff --git a/drivers/clk/qcom/dispcc-sc8280xp.c b/drivers/clk/qcom/dispcc-sc8280xp.c
> index 167470beb369..c84a6481b879 100644
> --- a/drivers/clk/qcom/dispcc-sc8280xp.c
> +++ b/drivers/clk/qcom/dispcc-sc8280xp.c
> @@ -3199,6 +3199,7 @@ static struct platform_driver disp_cc_sc8280xp_driver = {
> .driver = {
> .name = "disp_cc-sc8280xp",
> .of_match_table = disp_cc_sc8280xp_match_table,
> + .sync_state = clk_sync_state_disable_unused,
> },
> };
>
> diff --git a/drivers/clk/qcom/gcc-sc8280xp.c b/drivers/clk/qcom/gcc-sc8280xp.c
> index b3198784e1c3..f4fdc5b9663c 100644
> --- a/drivers/clk/qcom/gcc-sc8280xp.c
> +++ b/drivers/clk/qcom/gcc-sc8280xp.c
> @@ -7441,6 +7441,7 @@ static struct platform_driver gcc_sc8280xp_driver = {
> .driver = {
> .name = "gcc-sc8280xp",
> .of_match_table = gcc_sc8280xp_match_table,
> + .sync_state = clk_sync_state_disable_unused,
> },
> };
>
> --
> 2.37.3
>
--
மணிவண்ணன் சதாசிவம்
^ permalink raw reply [flat|nested] 6+ messages in thread
* Re: [PATCH] clk: qcom: Remove need for clk_ignore_unused on sc8280xp
2023-01-13 4:10 [PATCH] clk: qcom: Remove need for clk_ignore_unused on sc8280xp Bjorn Andersson
` (2 preceding siblings ...)
2023-01-15 4:12 ` Manivannan Sadhasivam
@ 2023-01-15 16:11 ` Abel Vesa
2023-01-17 18:24 ` Bjorn Andersson
4 siblings, 0 replies; 6+ messages in thread
From: Abel Vesa @ 2023-01-15 16:11 UTC (permalink / raw)
To: Bjorn Andersson
Cc: Bjorn Andersson, Konrad Dybcio, Michael Turquette, Stephen Boyd,
linux-arm-msm, linux-clk, linux-kernel
On 23-01-12 20:10:38, Bjorn Andersson wrote:
> With the transition of disabling unused clocks at sync_state, rather
> than late_initcall() it's now possible to drop clk_ignore_unused and
> unused clock disabled once client drivers have probed. Do this on
> SC8280XP.
>
> Signed-off-by: Bjorn Andersson <quic_bjorande@quicinc.com>
Reviewed-by: Abel Vesa <abel.vesa@linaro.org>
> ---
> drivers/clk/qcom/dispcc-sc8280xp.c | 1 +
> drivers/clk/qcom/gcc-sc8280xp.c | 1 +
> 2 files changed, 2 insertions(+)
>
> diff --git a/drivers/clk/qcom/dispcc-sc8280xp.c b/drivers/clk/qcom/dispcc-sc8280xp.c
> index 167470beb369..c84a6481b879 100644
> --- a/drivers/clk/qcom/dispcc-sc8280xp.c
> +++ b/drivers/clk/qcom/dispcc-sc8280xp.c
> @@ -3199,6 +3199,7 @@ static struct platform_driver disp_cc_sc8280xp_driver = {
> .driver = {
> .name = "disp_cc-sc8280xp",
> .of_match_table = disp_cc_sc8280xp_match_table,
> + .sync_state = clk_sync_state_disable_unused,
> },
> };
>
> diff --git a/drivers/clk/qcom/gcc-sc8280xp.c b/drivers/clk/qcom/gcc-sc8280xp.c
> index b3198784e1c3..f4fdc5b9663c 100644
> --- a/drivers/clk/qcom/gcc-sc8280xp.c
> +++ b/drivers/clk/qcom/gcc-sc8280xp.c
> @@ -7441,6 +7441,7 @@ static struct platform_driver gcc_sc8280xp_driver = {
> .driver = {
> .name = "gcc-sc8280xp",
> .of_match_table = gcc_sc8280xp_match_table,
> + .sync_state = clk_sync_state_disable_unused,
> },
> };
>
> --
> 2.37.3
>
^ permalink raw reply [flat|nested] 6+ messages in thread
* Re: [PATCH] clk: qcom: Remove need for clk_ignore_unused on sc8280xp
2023-01-13 4:10 [PATCH] clk: qcom: Remove need for clk_ignore_unused on sc8280xp Bjorn Andersson
` (3 preceding siblings ...)
2023-01-15 16:11 ` Abel Vesa
@ 2023-01-17 18:24 ` Bjorn Andersson
4 siblings, 0 replies; 6+ messages in thread
From: Bjorn Andersson @ 2023-01-17 18:24 UTC (permalink / raw)
To: sboyd, abel.vesa, quic_bjorande, mturquette, konrad.dybcio
Cc: linux-clk, linux-kernel, linux-arm-msm
On Thu, 12 Jan 2023 20:10:38 -0800, Bjorn Andersson wrote:
> With the transition of disabling unused clocks at sync_state, rather
> than late_initcall() it's now possible to drop clk_ignore_unused and
> unused clock disabled once client drivers have probed. Do this on
> SC8280XP.
>
>
Applied, thanks!
[1/1] clk: qcom: Remove need for clk_ignore_unused on sc8280xp
commit: 29e31415e14e16e25d428205c7230400dea1d7cf
Best regards,
--
Bjorn Andersson <andersson@kernel.org>
^ permalink raw reply [flat|nested] 6+ messages in thread
end of thread, other threads:[~2023-01-17 19:22 UTC | newest]
Thread overview: 6+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2023-01-13 4:10 [PATCH] clk: qcom: Remove need for clk_ignore_unused on sc8280xp Bjorn Andersson
2023-01-13 4:16 ` Konrad Dybcio
2023-01-13 20:14 ` Andrew Halaney
2023-01-15 4:12 ` Manivannan Sadhasivam
2023-01-15 16:11 ` Abel Vesa
2023-01-17 18:24 ` Bjorn Andersson
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox