* [PATCH] s390/ipl: Use kstrtobool() instead of strtobool() (second step)
@ 2023-01-14 15:08 Christophe JAILLET
2023-01-15 20:34 ` Heiko Carstens
0 siblings, 1 reply; 2+ messages in thread
From: Christophe JAILLET @ 2023-01-14 15:08 UTC (permalink / raw)
To: Heiko Carstens, Vasily Gorbik, Alexander Gordeev,
Christian Borntraeger, Sven Schnelle
Cc: linux-kernel, kernel-janitors, Christophe JAILLET, linux-s390
strtobool() is the same as kstrtobool().
However, the latter is more used within the kernel.
In order to remove strtobool() and slightly simplify kstrtox.h, switch to
the other function name.
Signed-off-by: Christophe JAILLET <christophe.jaillet@wanadoo.fr>
---
This patch is similar to the serie ([1]) that tries to axed all usages
of strtobool().
Most of the patches have been merged in -next.
Commit d9b25bdf57e4 ("s390/ipl: Use kstrtobool() instead of strtobool()")
already fixed this file, but a new usage has been introduce by commit
87fd22e0ae92 ("s390/ipl: add eckd support").
This patch has been cross-compiled with make.cross.
[1]: https://lore.kernel.org/all/cover.1667336095.git.christophe.jaillet@wanadoo.fr/
---
arch/s390/kernel/ipl.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/arch/s390/kernel/ipl.c b/arch/s390/kernel/ipl.c
index fbd646dbf440..5547223acce0 100644
--- a/arch/s390/kernel/ipl.c
+++ b/arch/s390/kernel/ipl.c
@@ -1194,7 +1194,7 @@ static ssize_t reipl_eckd_clear_store(struct kobject *kobj,
struct kobj_attribute *attr,
const char *buf, size_t len)
{
- if (strtobool(buf, &reipl_eckd_clear) < 0)
+ if (kstrtobool(buf, &reipl_eckd_clear) < 0)
return -EINVAL;
return len;
}
--
2.34.1
^ permalink raw reply related [flat|nested] 2+ messages in thread
* Re: [PATCH] s390/ipl: Use kstrtobool() instead of strtobool() (second step)
2023-01-14 15:08 [PATCH] s390/ipl: Use kstrtobool() instead of strtobool() (second step) Christophe JAILLET
@ 2023-01-15 20:34 ` Heiko Carstens
0 siblings, 0 replies; 2+ messages in thread
From: Heiko Carstens @ 2023-01-15 20:34 UTC (permalink / raw)
To: Christophe JAILLET
Cc: Vasily Gorbik, Alexander Gordeev, Christian Borntraeger,
Sven Schnelle, linux-kernel, kernel-janitors, linux-s390
On Sat, Jan 14, 2023 at 04:08:22PM +0100, Christophe JAILLET wrote:
> strtobool() is the same as kstrtobool().
> However, the latter is more used within the kernel.
>
> In order to remove strtobool() and slightly simplify kstrtox.h, switch to
> the other function name.
>
> Signed-off-by: Christophe JAILLET <christophe.jaillet@wanadoo.fr>
> ---
> This patch is similar to the serie ([1]) that tries to axed all usages
> of strtobool().
> Most of the patches have been merged in -next.
>
> Commit d9b25bdf57e4 ("s390/ipl: Use kstrtobool() instead of strtobool()")
> already fixed this file, but a new usage has been introduce by commit
> 87fd22e0ae92 ("s390/ipl: add eckd support").
>
> This patch has been cross-compiled with make.cross.
>
> [1]: https://lore.kernel.org/all/cover.1667336095.git.christophe.jaillet@wanadoo.fr/
> ---
> arch/s390/kernel/ipl.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
Applied, thanks!
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2023-01-15 20:35 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2023-01-14 15:08 [PATCH] s390/ipl: Use kstrtobool() instead of strtobool() (second step) Christophe JAILLET
2023-01-15 20:34 ` Heiko Carstens
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox