From: Tony Lindgren <tony@atomide.com>
To: Bartosz Golaszewski <brgl@bgdev.pl>
Cc: Andreas Kemnade <andreas@kemnade.info>,
grygorii.strashko@ti.com, ssantosh@kernel.org,
khilman@kernel.org, linus.walleij@linaro.org,
linux-omap@vger.kernel.org, linux-gpio@vger.kernel.org,
linux-kernel@vger.kernel.org
Subject: Re: [PATCH] gpio: omap: use dynamic allocation of base
Date: Mon, 16 Jan 2023 19:14:02 +0200 [thread overview]
Message-ID: <Y8WF2gXbrGnDLQ+S@atomide.com> (raw)
In-Reply-To: <CAMRc=Mf4-8AfTHLrvaF14tc2TJatxZJWnMOF-1G8HmDhPKSFAw@mail.gmail.com>
* Bartosz Golaszewski <brgl@bgdev.pl> [230116 08:38]:
> On Fri, Jan 13, 2023 at 9:59 PM Andreas Kemnade <andreas@kemnade.info> wrote:
> > diff --git a/drivers/gpio/gpio-omap.c b/drivers/gpio/gpio-omap.c
> > index 80ddc43fd875..f5f3d4b22452 100644
> > --- a/drivers/gpio/gpio-omap.c
> > +++ b/drivers/gpio/gpio-omap.c
> > @@ -1020,7 +1020,7 @@ static int omap_gpio_chip_init(struct gpio_bank *bank, struct irq_chip *irqc,
> > if (!label)
> > return -ENOMEM;
> > bank->chip.label = label;
> > - bank->chip.base = gpio;
> > + bank->chip.base = -1;
> > }
> > bank->chip.ngpio = bank->width;
> >
> > --
> > 2.30.2
> >
>
> This could potentially break some legacy user-space programs using
> sysfs but whatever, let's apply it and see if anyone complains.
Worth a try for sure, fingers crossed. I guess /sys/class/gpio will
break at least.
Regards,
Tony
next prev parent reply other threads:[~2023-01-16 17:37 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-01-13 20:59 [PATCH] gpio: omap: use dynamic allocation of base Andreas Kemnade
2023-01-16 8:38 ` Bartosz Golaszewski
2023-01-16 17:14 ` Tony Lindgren [this message]
2024-08-29 8:52 ` Richard Weinberger
2024-08-30 22:46 ` Linus Walleij
2024-08-31 7:32 ` Richard Weinberger
2023-01-16 14:24 ` Linus Walleij
2023-01-16 17:08 ` Andreas Kemnade
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=Y8WF2gXbrGnDLQ+S@atomide.com \
--to=tony@atomide.com \
--cc=andreas@kemnade.info \
--cc=brgl@bgdev.pl \
--cc=grygorii.strashko@ti.com \
--cc=khilman@kernel.org \
--cc=linus.walleij@linaro.org \
--cc=linux-gpio@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-omap@vger.kernel.org \
--cc=ssantosh@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox