From: Ingo Molnar <mingo@kernel.org>
To: Shuah Khan <skhan@linuxfoundation.org>
Cc: Mathieu Desnoyers <mathieu.desnoyers@efficios.com>,
kernel test robot <lkp@intel.com>, Shuah Khan <shuah@kernel.org>,
oe-kbuild-all@lists.linux.dev, linux-kernel@vger.kernel.org,
x86@kernel.org, Peter Zijlstra <peterz@infradead.org>,
linux-kselftest@vger.kernel.org
Subject: Re: [tip:sched/core 7/28] rseq.c:139:37: error: 'AT_RSEQ_ALIGN' undeclared; did you mean 'R_SH_ALIGN'?
Date: Tue, 17 Jan 2023 10:06:48 +0100 [thread overview]
Message-ID: <Y8ZlKOsN1wGk9tTc@gmail.com> (raw)
In-Reply-To: <4449d8b5-b7a5-0f09-5b42-7b70ba00f8f6@linuxfoundation.org>
* Shuah Khan <skhan@linuxfoundation.org> wrote:
> On 1/16/23 13:18, Mathieu Desnoyers wrote:
> > On 2023-01-16 14:40, kernel test robot wrote:
> > > tree: https://git.kernel.org/pub/scm/linux/kernel/git/tip/tip.git sched/core
> > > head: 79ba1e607d68178db7d3fe4f6a4aa38f06805e7b
> > > commit: 03f5c0272d1b59343144e199becc911dae52c37e [7/28] selftests/rseq: Use ELF auxiliary vector for extensible rseq
> > > compiler: gcc-11 (Debian 11.3.0-8) 11.3.0
> > > reproduce:
> > > # https://git.kernel.org/pub/scm/linux/kernel/git/tip/tip.git/commit/?id=03f5c0272d1b59343144e199becc911dae52c37e
> > > git remote add tip https://git.kernel.org/pub/scm/linux/kernel/git/tip/tip.git
> > > git fetch --no-tags tip sched/core
> > > git checkout 03f5c0272d1b59343144e199becc911dae52c37e
> > > make O=/tmp/kselftest headers
> > > make O=/tmp/kselftest -C tools/testing/selftests
> > >
> > > If you fix the issue, kindly add following tag where applicable
> > > | Reported-by: kernel test robot <lkp@intel.com>
> >
> > In order to fix this, I need to change -I../../../../usr/include/ for $(KHDR_INCLUDES) in tools/testing/selftests/rseq/Makefile
> >
> > I can find 25 odd uses of the same pattern in the kernel selftests. Should I fix them all in one go ?
>
> kselftest build depends on headers installed in the root directory.
> The main makefile enforces this dependency. If this test is being
> built without installing headers by itself, I think the scripts that
> build individual tests have to makes sure headers are installed first.
Why isn't the Makefile saying anything about it & enforcing it? self-tests
are usually self-sufficient to build in the individual directories.
Thanks,
Ingo
next prev parent reply other threads:[~2023-01-17 9:15 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-01-16 19:40 [tip:sched/core 7/28] rseq.c:139:37: error: 'AT_RSEQ_ALIGN' undeclared; did you mean 'R_SH_ALIGN'? kernel test robot
2023-01-16 20:18 ` Mathieu Desnoyers
2023-01-16 23:38 ` Shuah Khan
2023-01-17 9:06 ` Ingo Molnar [this message]
2023-01-17 17:44 ` Mathieu Desnoyers
2023-01-17 19:11 ` Shuah Khan
2023-01-17 20:14 ` Mathieu Desnoyers
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=Y8ZlKOsN1wGk9tTc@gmail.com \
--to=mingo@kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-kselftest@vger.kernel.org \
--cc=lkp@intel.com \
--cc=mathieu.desnoyers@efficios.com \
--cc=oe-kbuild-all@lists.linux.dev \
--cc=peterz@infradead.org \
--cc=shuah@kernel.org \
--cc=skhan@linuxfoundation.org \
--cc=x86@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox