From: Wolfram Sang <wsa@kernel.org>
To: Bartosz Golaszewski <brgl@bgdev.pl>
Cc: linux-i2c@vger.kernel.org, linux-kernel@vger.kernel.org,
Bartosz Golaszewski <bartosz.golaszewski@linaro.org>
Subject: Re: [PATCH v2 1/2] i2c: dev: fix notifier return values
Date: Tue, 17 Jan 2023 11:04:32 +0100 [thread overview]
Message-ID: <Y8ZysLbYYN4OurlP@ninjato> (raw)
In-Reply-To: <20221229160045.535778-2-brgl@bgdev.pl>
[-- Attachment #1: Type: text/plain, Size: 547 bytes --]
On Thu, Dec 29, 2022 at 05:00:44PM +0100, Bartosz Golaszewski wrote:
> From: Bartosz Golaszewski <bartosz.golaszewski@linaro.org>
>
> We have a set of return values that notifier callbacks can return. They
> should not return 0, error codes or anything other than those predefined
> values. Make the i2c character device's callback return NOTIFY_DONE or
> NOTIFY_OK depending on the situation.
>
> Signed-off-by: Bartosz Golaszewski <bartosz.golaszewski@linaro.org>
Applied to for-next, thanks!
I start reviewing patch 2 now...
[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 833 bytes --]
next prev parent reply other threads:[~2023-01-17 10:04 UTC|newest]
Thread overview: 16+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-12-29 16:00 [PATCH v2 0/2] i2c: fortify the subsystem against user-space induced deadlocks Bartosz Golaszewski
2022-12-29 16:00 ` [PATCH v2 1/2] i2c: dev: fix notifier return values Bartosz Golaszewski
2023-01-17 10:04 ` Wolfram Sang [this message]
2023-03-08 16:58 ` Geert Uytterhoeven
2023-03-08 19:33 ` Bartosz Golaszewski
2023-03-08 19:51 ` Geert Uytterhoeven
2023-03-09 7:47 ` Geert Uytterhoeven
2022-12-29 16:00 ` [PATCH v2 2/2] i2c: dev: don't allow user-space to deadlock the kernel Bartosz Golaszewski
2023-01-17 10:08 ` Wolfram Sang
2023-01-17 10:10 ` Bartosz Golaszewski
2023-01-17 10:26 ` Wolfram Sang
2023-01-17 18:57 ` Wolfram Sang
2023-01-18 12:51 ` Bartosz Golaszewski
[not found] ` <20230118145914.3012-1-hdanton@sina.com>
2023-01-18 15:07 ` Bartosz Golaszewski
2023-01-12 9:01 ` [PATCH v2 0/2] i2c: fortify the subsystem against user-space induced deadlocks Bartosz Golaszewski
2023-01-12 9:09 ` Wolfram Sang
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=Y8ZysLbYYN4OurlP@ninjato \
--to=wsa@kernel.org \
--cc=bartosz.golaszewski@linaro.org \
--cc=brgl@bgdev.pl \
--cc=linux-i2c@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox