public inbox for linux-kernel@vger.kernel.org
 help / color / mirror / Atom feed
From: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
To: "Alvin Šipraga" <alvin@pqrs.dk>
Cc: "Alvin Šipraga" <alsi@bang-olufsen.dk>,
	linux-usb@vger.kernel.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH] usb: gadget: u_ether: remove obnoxious warning messages
Date: Tue, 17 Jan 2023 16:04:35 +0100	[thread overview]
Message-ID: <Y8a5A/6cuiPWdyDl@kroah.com> (raw)
In-Reply-To: <20221209172853.2138941-1-alvin@pqrs.dk>

On Fri, Dec 09, 2022 at 06:28:53PM +0100, Alvin Šipraga wrote:
> From: Alvin Šipraga <alsi@bang-olufsen.dk>
> 
> There is really no need for the driver to unconditionally emit warnings
> like this on every usage:
> 
> [    6.967283] using random self ethernet address
> [    6.967294] using random host ethernet address
> 
> Since this is normal behaviour, just remove the messages altogether.
> 
> Signed-off-by: Alvin Šipraga <alsi@bang-olufsen.dk>
> ---
>  drivers/usb/gadget/function/u_ether.c | 2 --
>  1 file changed, 2 deletions(-)

Please see the thread at:
	https://lore.kernel.org/r/20230116155545.101391-1-jonathanh@nvidia.com

for more details.

This should use dev_warn() or better yet, just dev_dbg().

thanks,

greg k-h

      parent reply	other threads:[~2023-01-17 15:05 UTC|newest]

Thread overview: 3+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2022-12-09 17:28 [PATCH] usb: gadget: u_ether: remove obnoxious warning messages Alvin Šipraga
2022-12-12  8:07 ` Andrzej Pietrasiewicz
2023-01-17 15:04 ` Greg Kroah-Hartman [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=Y8a5A/6cuiPWdyDl@kroah.com \
    --to=gregkh@linuxfoundation.org \
    --cc=alsi@bang-olufsen.dk \
    --cc=alvin@pqrs.dk \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-usb@vger.kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox