From: Conor Dooley <conor.dooley@microchip.com>
To: Nylon Chen <nylon.chen@sifive.com>
Cc: <paul.walmsley@sifive.com>, <palmer@dabbelt.com>,
<linux-kernel@vger.kernel.org>, <linux-riscv@lists.infradead.org>,
<nylon7717@gmail.com>, <zong.li@sifive.com>,
<greentime.hu@sifive.com>, <vincent.chen@sifive.com>
Subject: Re: [PATCH 1/2] riscv: dts: sifive unmatched: Remove PWM controlled LED's active-low properties
Date: Tue, 17 Jan 2023 13:57:48 +0000 [thread overview]
Message-ID: <Y8apXMzlDYhuLOqV@wendy> (raw)
In-Reply-To: <20230113083115.2590-2-nylon.chen@sifive.com>
[-- Attachment #1: Type: text/plain, Size: 1534 bytes --]
Hey Nylon,
On Fri, Jan 13, 2023 at 04:31:14PM +0800, Nylon Chen wrote:
> This removes the active-low properties of the PWM-controlled LEDs in
> the HiFive Unmatched device tree.
Does unleashed also have the same issue?
It has the same compatible at the very least.
Thanks,
Conor.
>
> Signed-off-by: Nylon Chen <nylon.chen@sifive.com>
> Reviewed-by: Vincent Chen <vincent.chen@sifive.com>
> ---
> arch/riscv/boot/dts/sifive/hifive-unmatched-a00.dts | 4 ----
> 1 file changed, 4 deletions(-)
>
> diff --git a/arch/riscv/boot/dts/sifive/hifive-unmatched-a00.dts b/arch/riscv/boot/dts/sifive/hifive-unmatched-a00.dts
> index 07387f9c135c..11f08a545ee6 100644
> --- a/arch/riscv/boot/dts/sifive/hifive-unmatched-a00.dts
> +++ b/arch/riscv/boot/dts/sifive/hifive-unmatched-a00.dts
> @@ -52,7 +52,6 @@ led-controller-1 {
>
> led-d12 {
> pwms = <&pwm0 0 7812500 PWM_POLARITY_INVERTED>;
> - active-low;
> color = <LED_COLOR_ID_GREEN>;
> max-brightness = <255>;
> label = "d12";
> @@ -69,19 +68,16 @@ multi-led {
>
> led-red {
> pwms = <&pwm0 2 7812500 PWM_POLARITY_INVERTED>;
> - active-low;
> color = <LED_COLOR_ID_RED>;
> };
>
> led-green {
> pwms = <&pwm0 1 7812500 PWM_POLARITY_INVERTED>;
> - active-low;
> color = <LED_COLOR_ID_GREEN>;
> };
>
> led-blue {
> pwms = <&pwm0 3 7812500 PWM_POLARITY_INVERTED>;
> - active-low;
> color = <LED_COLOR_ID_BLUE>;
> };
> };
> --
> 2.36.1
>
[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 228 bytes --]
next prev parent reply other threads:[~2023-01-17 13:59 UTC|newest]
Thread overview: 14+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-01-13 8:31 [PATCH 0/2] Change PWM-controlled LED pin active mode and algorithm Nylon Chen
2023-01-13 8:31 ` [PATCH 1/2] riscv: dts: sifive unmatched: Remove PWM controlled LED's active-low properties Nylon Chen
2023-01-17 13:57 ` Conor Dooley [this message]
2023-01-13 8:31 ` [PATCH 2/2] pwm: sifive: change the PWM controlled LED algorithm Nylon Chen
2023-01-13 18:32 ` [PATCH 0/2] Change PWM-controlled LED pin active mode and algorithm Conor Dooley
2023-01-13 19:24 ` Jessica Clarke
2023-01-14 14:00 ` Conor Dooley
2023-01-18 2:32 ` Nylon Chen
2023-01-18 8:13 ` Conor Dooley
2023-01-17 9:32 ` Nylon Chen
2023-01-17 15:08 ` Ron Economos
2023-01-18 1:46 ` Ron Economos
2023-01-18 3:40 ` Ron Economos
2023-01-18 2:30 ` Nylon Chen
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=Y8apXMzlDYhuLOqV@wendy \
--to=conor.dooley@microchip.com \
--cc=greentime.hu@sifive.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-riscv@lists.infradead.org \
--cc=nylon.chen@sifive.com \
--cc=nylon7717@gmail.com \
--cc=palmer@dabbelt.com \
--cc=paul.walmsley@sifive.com \
--cc=vincent.chen@sifive.com \
--cc=zong.li@sifive.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox