From: Alexandre Belloni <alexandre.belloni@bootlin.com>
To: Arnd Bergmann <arnd@kernel.org>
Cc: Vincent Shih <vincent.sunplus@gmail.com>,
Alessandro Zummo <a.zummo@towertech.it>,
Arnd Bergmann <arnd@arndb.de>,
linux-rtc@vger.kernel.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH] rtc: sunplus: fix format string for printing resource
Date: Tue, 17 Jan 2023 18:55:14 +0100 [thread overview]
Message-ID: <Y8bhApoC4Bmgtjoq@mail.local> (raw)
In-Reply-To: <20230117172450.2938962-1-arnd@kernel.org>
On 17/01/2023 18:24:44+0100, Arnd Bergmann wrote:
> From: Arnd Bergmann <arnd@arndb.de>
>
> On 32-bit architectures with 64-bit resource_size_t, sp_rtc_probe()
> causes a compiler warning:
>
> drivers/rtc/rtc-sunplus.c: In function 'sp_rtc_probe':
> drivers/rtc/rtc-sunplus.c:243:33: error: format '%x' expects argument of type 'unsigned int', but argument 4 has type 'resource_size_t' {aka 'long long unsigned int'} [-Werror=format=]
> 243 | dev_dbg(&plat_dev->dev, "res = 0x%x, reg_base = 0x%lx\n",
> | ^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
>
> The best way to print a resource is the special %pR format string,
> and similarly to print a pointer we can use %p and avoid the cast.
>
I got this one this morning, which one is more correct? :)
https://lore.kernel.org/all/20230117054232.24023-1-rdunlap@infradead.org/
> Fixes: fad6cbe9b2b4 ("rtc: Add driver for RTC in Sunplus SP7021")
> Signed-off-by: Arnd Bergmann <arnd@arndb.de>
> ---
> drivers/rtc/rtc-sunplus.c | 4 ++--
> 1 file changed, 2 insertions(+), 2 deletions(-)
>
> diff --git a/drivers/rtc/rtc-sunplus.c b/drivers/rtc/rtc-sunplus.c
> index e8e2ab1103fc..4b578e4d44f6 100644
> --- a/drivers/rtc/rtc-sunplus.c
> +++ b/drivers/rtc/rtc-sunplus.c
> @@ -240,8 +240,8 @@ static int sp_rtc_probe(struct platform_device *plat_dev)
> if (IS_ERR(sp_rtc->reg_base))
> return dev_err_probe(&plat_dev->dev, PTR_ERR(sp_rtc->reg_base),
> "%s devm_ioremap_resource fail\n", RTC_REG_NAME);
> - dev_dbg(&plat_dev->dev, "res = 0x%x, reg_base = 0x%lx\n",
> - sp_rtc->res->start, (unsigned long)sp_rtc->reg_base);
> + dev_dbg(&plat_dev->dev, "res = %pR, reg_base = %p\n",
> + sp_rtc->res, sp_rtc->reg_base);
>
> sp_rtc->irq = platform_get_irq(plat_dev, 0);
> if (sp_rtc->irq < 0)
> --
> 2.39.0
>
--
Alexandre Belloni, co-owner and COO, Bootlin
Embedded Linux and Kernel engineering
https://bootlin.com
next prev parent reply other threads:[~2023-01-17 18:20 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-01-17 17:24 [PATCH] rtc: sunplus: fix format string for printing resource Arnd Bergmann
2023-01-17 17:55 ` Alexandre Belloni [this message]
2023-01-17 18:24 ` Randy Dunlap
2023-01-17 19:36 ` Arnd Bergmann
2023-01-18 0:56 ` Randy Dunlap
2023-01-23 22:34 ` Alexandre Belloni
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=Y8bhApoC4Bmgtjoq@mail.local \
--to=alexandre.belloni@bootlin.com \
--cc=a.zummo@towertech.it \
--cc=arnd@arndb.de \
--cc=arnd@kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-rtc@vger.kernel.org \
--cc=vincent.sunplus@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox