From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id 323F4C677F1 for ; Tue, 17 Jan 2023 18:46:25 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S234053AbjAQSqE (ORCPT ); Tue, 17 Jan 2023 13:46:04 -0500 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:60696 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S235160AbjAQSjz (ORCPT ); Tue, 17 Jan 2023 13:39:55 -0500 Received: from dfw.source.kernel.org (dfw.source.kernel.org [139.178.84.217]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 29AE31E287 for ; Tue, 17 Jan 2023 10:11:57 -0800 (PST) Received: from smtp.kernel.org (relay.kernel.org [52.25.139.140]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by dfw.source.kernel.org (Postfix) with ESMTPS id BC508614FC for ; Tue, 17 Jan 2023 18:11:56 +0000 (UTC) Received: by smtp.kernel.org (Postfix) with ESMTPSA id 961E2C433F0; Tue, 17 Jan 2023 18:11:55 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=linuxfoundation.org; s=korg; t=1673979116; bh=C34Ci/xYdbH/8oLA3YDDw/yrOZeRQzsgzaXlxYuh1Sk=; h=Date:From:To:Cc:Subject:References:In-Reply-To:From; b=tBsL+P/Pnhp3jwwebsmkMk0ME7nkJ/guAhYZ7OtOvxE7lQxJhjpNkuwamrPGpZRtV hx8P8u8ZaxjPlwzirpgCpwG4l5WGiVi27LTiL72a5xpbcoFi09lOGXU9IoPy2qjR+b aLAIuPhs1vszPNPYF40qirKWUHkZxMOne8a1nD3c= Date: Tue, 17 Jan 2023 19:11:53 +0100 From: Greg Kroah-Hartman To: Soha Jin Cc: "Rafael J. Wysocki" , linux-kernel@vger.kernel.org Subject: Re: [PATCH driver-core-next] platform: remove useless if-branch in __platform_get_irq_byname() Message-ID: References: <20221111094542.270540-1-soha@lohu.info> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20221111094542.270540-1-soha@lohu.info> Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Fri, Nov 11, 2022 at 05:45:42PM +0800, Soha Jin wrote: > When CONFIG_OF_IRQ is not enabled, there will be a stub method that always > returns 0 when getting IRQ. Thus, the if-branch can be removed safely. > > Fixes: d4ad017d6345 ("platform: use fwnode_irq_get_byname instead of of_irq_get_byname to get irq") > Signed-off-by: Soha Jin > --- > drivers/base/platform.c | 8 +++----- > 1 file changed, 3 insertions(+), 5 deletions(-) > > diff --git a/drivers/base/platform.c b/drivers/base/platform.c > index 968f3d71eeab..6cd7fd478c5f 100644 > --- a/drivers/base/platform.c > +++ b/drivers/base/platform.c > @@ -441,11 +441,9 @@ static int __platform_get_irq_byname(struct platform_device *dev, > struct resource *r; > int ret; > > - if (!dev->dev.of_node || IS_ENABLED(CONFIG_OF_IRQ)) { > - ret = fwnode_irq_get_byname(dev_fwnode(&dev->dev), name); > - if (ret > 0 || ret == -EPROBE_DEFER) > - return ret; > - } > + ret = fwnode_irq_get_byname(dev_fwnode(&dev->dev), name); > + if (ret > 0 || ret == -EPROBE_DEFER) > + return ret; It's not really a "fix", so I'll be dropping that tag here. thanks, greg k-h