From: Vinod Koul <vkoul@kernel.org>
To: Koba Ko <koba.ko@canonical.com>
Cc: dmaengine@vger.kernel.org, linux-kernel@vger.kernel.org,
Jerry Snitselaar <jsnitsel@redhat.com>,
Jie Hai <haijie1@huawei.com>, Dave Jiang <dave.jiang@intel.com>,
Joel Savitz <jsavitz@redhat.com>
Subject: Re: [PATCH V3] dmaengine: Fix double increment of client_count in dma_chan_get()
Date: Wed, 18 Jan 2023 17:36:59 +0530 [thread overview]
Message-ID: <Y8fg44HzvwY3Bb8N@matsya> (raw)
In-Reply-To: <20221201030050.978595-1-koba.ko@canonical.com>
On 01-12-22, 11:00, Koba Ko wrote:
> The first time dma_chan_get() is called for a channel the channel
> client_count is incorrectly incremented twice for public channels,
> first in balance_ref_count(), and again prior to returning. This
> results in an incorrect client count which will lead to the
> channel resources not being freed when they should be. A simple
> test of repeated module load and unload of async_tx on a Dell
> Power Edge R7425 also shows this resulting in a kref underflow
> warning.
Applied, thanks
--
~Vinod
prev parent reply other threads:[~2023-01-18 12:45 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-12-01 3:00 [PATCH V3] dmaengine: Fix double increment of client_count in dma_chan_get() Koba Ko
2022-12-02 18:57 ` Joel Savitz
2023-01-03 8:18 ` Joel Savitz
2023-01-18 12:06 ` Vinod Koul [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=Y8fg44HzvwY3Bb8N@matsya \
--to=vkoul@kernel.org \
--cc=dave.jiang@intel.com \
--cc=dmaengine@vger.kernel.org \
--cc=haijie1@huawei.com \
--cc=jsavitz@redhat.com \
--cc=jsnitsel@redhat.com \
--cc=koba.ko@canonical.com \
--cc=linux-kernel@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox