From: Tony Lindgren <tony@atomide.com>
To: Adam Ford <aford173@gmail.com>
Cc: Andreas Kemnade <andreas@kemnade.info>,
bcousson@baylibre.com, robh+dt@kernel.org,
krzysztof.kozlowski+dt@linaro.org, linux-omap@vger.kernel.org,
devicetree@vger.kernel.org, linux-kernel@vger.kernel.org,
"H. Nikolaus Schaller" <hns@goldelico.com>
Subject: Re: [PATCH] ARM: dts: gta04: fix excess dma channel usage
Date: Thu, 19 Jan 2023 09:30:20 +0200 [thread overview]
Message-ID: <Y8jxjBZrPV0n363P@atomide.com> (raw)
In-Reply-To: <Y8WEoxiOXgZNB1Oc@atomide.com>
* Tony Lindgren <tony@atomide.com> [230116 17:33]:
> * Adam Ford <aford173@gmail.com> [230116 17:00]:
> > Doesn't this imply the target-module stuff needs to be implemented for
> > the drivers? It looks like a lot of the omap3 drivers are still using
> > hwmods although some have target-modules. In this case, the mcspi
> > drivers that Andreas is disabling don't appear to have target-module
> > stuff configured.
>
> Sorry I don't remember if omap_device.c ignores status disabled or not.
> But in any case, it should be trivial to update omap3.dtsi to configure
> some of the devices like mcspi to probe with device tree data and ti-sysc
> as needed.
So as long as gta04 power management still behaves with this patch it
should good to go.
Just to note, if mcspi is at some point is updated to probe with ti-sysc,
the disabled flag needs to be kept at the mcspi child node, not at the
sysc target module level to idle the unused devices.
Regards,
Tony
next prev parent reply other threads:[~2023-01-19 7:30 UTC|newest]
Thread overview: 13+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-01-13 21:11 [PATCH] ARM: dts: gta04: fix excess dma channel usage Andreas Kemnade
2023-01-16 14:16 ` Adam Ford
2023-01-16 14:51 ` Tony Lindgren
2023-01-16 15:29 ` H. Nikolaus Schaller
2023-01-16 17:00 ` Tony Lindgren
2023-01-16 16:39 ` Andreas Kemnade
2023-01-16 16:56 ` Tony Lindgren
2023-01-16 17:00 ` Adam Ford
2023-01-16 17:08 ` Tony Lindgren
2023-01-19 7:30 ` Tony Lindgren [this message]
2023-01-22 9:08 ` Andreas Kemnade
2024-11-07 9:35 ` Andreas Kemnade
2023-03-27 8:13 ` Tony Lindgren
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=Y8jxjBZrPV0n363P@atomide.com \
--to=tony@atomide.com \
--cc=aford173@gmail.com \
--cc=andreas@kemnade.info \
--cc=bcousson@baylibre.com \
--cc=devicetree@vger.kernel.org \
--cc=hns@goldelico.com \
--cc=krzysztof.kozlowski+dt@linaro.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-omap@vger.kernel.org \
--cc=robh+dt@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox