From: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
To: Umang Jain <umang.jain@ideasonboard.com>
Cc: linux-staging@lists.linux.dev,
linux-rpi-kernel@lists.infradead.org,
linux-arm-kernel@lists.infradead.org,
linux-media@vger.kernel.org, linux-kernel@vger.kernel.org,
Stefan Wahren <stefan.wahren@i2se.com>,
Florian Fainelli <f.fainelli@gmail.com>,
Adrien Thierry <athierry@redhat.com>,
Dan Carpenter <error27@gmail.com>,
Dave Stevenson <dave.stevenson@raspberrypi.com>,
Kieran Bingham <kieran.bingham@ideasonboard.com>,
Laurent Pinchart <laurent.pinchart@ideasonboard.com>
Subject: Re: [RFC PATCH 0/4] Drop custom logging
Date: Thu, 19 Jan 2023 10:34:16 +0100 [thread overview]
Message-ID: <Y8kOmFWG/korDc5Y@kroah.com> (raw)
In-Reply-To: <20230118115810.21979-1-umang.jain@ideasonboard.com>
On Wed, Jan 18, 2023 at 05:28:06PM +0530, Umang Jain wrote:
> Drop custom logging from the vchiq interface.
> Mostly of them are replaced with dev_dbg and friends
> and/or pr_info and friends.
Everything should be dev_*() calls, there should never be a pr_* call in
a driver.
> The debugfs log levels (in 4/4) are mapped to kernel
> logs levels (coming from include/linux/kern_levels.h)
> Would like some thoughts on it as I am not sure (hence
> marking this is RFC)
Do not have any "custom" debugging controls in a driver, they are not
special and should follow the whole rest of the kernel. Just remove
them all and rely on the existing dev_*() calls instead please.
thanks,
greg k-h
next prev parent reply other threads:[~2023-01-20 5:03 UTC|newest]
Thread overview: 25+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-01-18 11:58 [RFC PATCH 0/4] Drop custom logging Umang Jain
2023-01-18 11:58 ` [RFC PATCH 1/4] staging: vc04_services: vchiq_core: " Umang Jain
2023-01-18 17:29 ` Stefan Wahren
2023-01-19 14:32 ` Dan Carpenter
2023-01-18 11:58 ` [RFC PATCH 2/4] staging: vc04_services: vchiq_arm: " Umang Jain
2023-01-18 11:58 ` [RFC PATCH 3/4] staging: vc04_services: " Umang Jain
2023-01-18 11:58 ` [RFC PATCH 4/4] staging: vc04_services: Drop remnants of " Umang Jain
2023-01-18 18:10 ` Stefan Wahren
2023-01-18 17:54 ` [RFC PATCH 0/4] Drop " Stefan Wahren
2023-01-19 5:11 ` Dan Carpenter
2023-01-19 13:31 ` Phil Elwell
2023-01-19 13:37 ` Greg Kroah-Hartman
2023-01-19 13:47 ` Phil Elwell
2023-01-19 14:25 ` Dan Carpenter
2023-01-19 14:31 ` Phil Elwell
2023-01-19 14:37 ` Dan Carpenter
2023-01-19 14:39 ` Phil Elwell
2023-01-20 0:53 ` Laurent Pinchart
2023-01-20 1:00 ` Laurent Pinchart
2023-01-23 12:04 ` Dan Carpenter
2023-01-19 9:34 ` Greg Kroah-Hartman [this message]
2023-01-22 14:21 ` Stefan Wahren
2023-01-22 16:26 ` Kieran Bingham
2023-01-22 18:07 ` Stefan Wahren
2023-01-23 16:54 ` Kieran Bingham
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=Y8kOmFWG/korDc5Y@kroah.com \
--to=gregkh@linuxfoundation.org \
--cc=athierry@redhat.com \
--cc=dave.stevenson@raspberrypi.com \
--cc=error27@gmail.com \
--cc=f.fainelli@gmail.com \
--cc=kieran.bingham@ideasonboard.com \
--cc=laurent.pinchart@ideasonboard.com \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-media@vger.kernel.org \
--cc=linux-rpi-kernel@lists.infradead.org \
--cc=linux-staging@lists.linux.dev \
--cc=stefan.wahren@i2se.com \
--cc=umang.jain@ideasonboard.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox