From: Andrew Lunn <andrew@lunn.ch>
To: Ahmad Fatoum <a.fatoum@pengutronix.de>
Cc: Jakub Kicinski <kuba@kernel.org>,
Woojung Huh <woojung.huh@microchip.com>,
UNGLinuxDriver@microchip.com,
Florian Fainelli <f.fainelli@gmail.com>,
Vladimir Oltean <olteanv@gmail.com>,
"David S. Miller" <davem@davemloft.net>,
Arun Ramadoss <arun.ramadoss@microchip.com>,
kernel@pengutronix.de, Oleksij Rempel <ore@pengutronix.de>,
Eric Dumazet <edumazet@google.com>,
Paolo Abeni <pabeni@redhat.com>,
netdev@vger.kernel.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH net] net: dsa: microchip: fix probe of I2C-connected KSZ8563
Date: Thu, 19 Jan 2023 14:56:52 +0100 [thread overview]
Message-ID: <Y8lMJI+SnnfxVMVe@lunn.ch> (raw)
In-Reply-To: <20230119131014.1228773-1-a.fatoum@pengutronix.de>
On Thu, Jan 19, 2023 at 02:10:15PM +0100, Ahmad Fatoum wrote:
> Starting with commit eee16b147121 ("net: dsa: microchip: perform the
> compatibility check for dev probed"), the KSZ switch driver now bails
> out if it thinks the DT compatible doesn't match the actual chip:
>
> ksz9477-switch 1-005f: Device tree specifies chip KSZ9893 but found
> KSZ8563, please fix it!
>
> Problem is that the "microchip,ksz8563" compatible is associated
> with ksz_switch_chips[KSZ9893]. Same issue also affected the SPI driver
> for the same switch chip and was fixed in commit b44908095612
> ("net: dsa: microchip: add separate struct ksz_chip_data for KSZ8563 chip").
>
> Reuse ksz_switch_chips[KSZ8563] introduced in aforementioned commit
> to get I2C-connected KSZ8563 probing again.
>
> Fixes: eee16b147121 ("net: dsa: microchip: perform the compatibility check for dev probed")
> Signed-off-by: Ahmad Fatoum <a.fatoum@pengutronix.de>
Reviewed-by: Andrew Lunn <andrew@lunn.ch>
Andrew
next prev parent reply other threads:[~2023-01-19 13:57 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-01-19 13:10 [PATCH net] net: dsa: microchip: fix probe of I2C-connected KSZ8563 Ahmad Fatoum
2023-01-19 13:56 ` Andrew Lunn [this message]
2023-01-20 7:01 ` Arun.Ramadoss
2023-01-20 7:57 ` Ahmad Fatoum
2023-01-20 10:38 ` Arun.Ramadoss
2023-01-20 10:42 ` Ahmad Fatoum
2023-01-20 10:47 ` Arun.Ramadoss
2023-01-20 13:08 ` Andrew Lunn
2023-01-20 13:15 ` Ahmad Fatoum
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=Y8lMJI+SnnfxVMVe@lunn.ch \
--to=andrew@lunn.ch \
--cc=UNGLinuxDriver@microchip.com \
--cc=a.fatoum@pengutronix.de \
--cc=arun.ramadoss@microchip.com \
--cc=davem@davemloft.net \
--cc=edumazet@google.com \
--cc=f.fainelli@gmail.com \
--cc=kernel@pengutronix.de \
--cc=kuba@kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=netdev@vger.kernel.org \
--cc=olteanv@gmail.com \
--cc=ore@pengutronix.de \
--cc=pabeni@redhat.com \
--cc=woojung.huh@microchip.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox