From: Dan Carpenter <error27@gmail.com>
To: Phil Elwell <phil@raspberrypi.com>
Cc: Greg Kroah-Hartman <gregkh@linuxfoundation.org>,
Stefan Wahren <stefan.wahren@i2se.com>,
Umang Jain <umang.jain@ideasonboard.com>,
linux-media@vger.kernel.org, linux-staging@lists.linux.dev,
linux-arm-kernel@lists.infradead.org,
linux-rpi-kernel@lists.infradead.org,
Florian Fainelli <f.fainelli@gmail.com>,
Adrien Thierry <athierry@redhat.com>,
Dave Stevenson <dave.stevenson@raspberrypi.com>,
Kieran Bingham <kieran.bingham@ideasonboard.com>,
Laurent Pinchart <laurent.pinchart@ideasonboard.com>,
linux-kernel@vger.kernel.org
Subject: Re: [RFC PATCH 0/4] Drop custom logging
Date: Thu, 19 Jan 2023 17:37:48 +0300 [thread overview]
Message-ID: <Y8lVvHMIYeSOLM5q@kadam> (raw)
In-Reply-To: <CAMEGJJ2b1KFQY1m1eTcvf8_kGBBTjzrBD2i_M2uR+6v4gEcbVQ@mail.gmail.com>
On Thu, Jan 19, 2023 at 02:31:50PM +0000, Phil Elwell wrote:
> On Thu, 19 Jan 2023 at 14:25, Dan Carpenter <error27@gmail.com> wrote:
> >
> > On Thu, Jan 19, 2023 at 01:47:44PM +0000, Phil Elwell wrote:
> > > > > I understand the desire to remove the custom logging. I don't welcome
> > > > > the loss of flexibility that comes with such a strategy
> > > >
> > > > What "loss of flexibility"? You now have access to the full dynamic
> > > > debugging facilities that all of the rest of the kernel has. What is
> > > > lacking?
> > >
> > > Perhaps I've missed something, either in this patch set or the kernel
> > > as a whole, but how is one supposed to set different logging levels on
> > > different facilities within a driver/module, or even for the module as
> > > a whole?
> >
> > Yeah. You will be still able to do that and more besides after the
> > transition. Cleaning this up makes the code better in every way.
> >
> > Documentation/admin-guide/dynamic-debug-howto.rst
>
> Are you saying this patch set gets us to that point?
Yes. The patch has some issues, but yes.
regards,
dan carpenter
next prev parent reply other threads:[~2023-01-19 14:40 UTC|newest]
Thread overview: 25+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-01-18 11:58 [RFC PATCH 0/4] Drop custom logging Umang Jain
2023-01-18 11:58 ` [RFC PATCH 1/4] staging: vc04_services: vchiq_core: " Umang Jain
2023-01-18 17:29 ` Stefan Wahren
2023-01-19 14:32 ` Dan Carpenter
2023-01-18 11:58 ` [RFC PATCH 2/4] staging: vc04_services: vchiq_arm: " Umang Jain
2023-01-18 11:58 ` [RFC PATCH 3/4] staging: vc04_services: " Umang Jain
2023-01-18 11:58 ` [RFC PATCH 4/4] staging: vc04_services: Drop remnants of " Umang Jain
2023-01-18 18:10 ` Stefan Wahren
2023-01-18 17:54 ` [RFC PATCH 0/4] Drop " Stefan Wahren
2023-01-19 5:11 ` Dan Carpenter
2023-01-19 13:31 ` Phil Elwell
2023-01-19 13:37 ` Greg Kroah-Hartman
2023-01-19 13:47 ` Phil Elwell
2023-01-19 14:25 ` Dan Carpenter
2023-01-19 14:31 ` Phil Elwell
2023-01-19 14:37 ` Dan Carpenter [this message]
2023-01-19 14:39 ` Phil Elwell
2023-01-20 0:53 ` Laurent Pinchart
2023-01-20 1:00 ` Laurent Pinchart
2023-01-23 12:04 ` Dan Carpenter
2023-01-19 9:34 ` Greg Kroah-Hartman
2023-01-22 14:21 ` Stefan Wahren
2023-01-22 16:26 ` Kieran Bingham
2023-01-22 18:07 ` Stefan Wahren
2023-01-23 16:54 ` Kieran Bingham
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=Y8lVvHMIYeSOLM5q@kadam \
--to=error27@gmail.com \
--cc=athierry@redhat.com \
--cc=dave.stevenson@raspberrypi.com \
--cc=f.fainelli@gmail.com \
--cc=gregkh@linuxfoundation.org \
--cc=kieran.bingham@ideasonboard.com \
--cc=laurent.pinchart@ideasonboard.com \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-media@vger.kernel.org \
--cc=linux-rpi-kernel@lists.infradead.org \
--cc=linux-staging@lists.linux.dev \
--cc=phil@raspberrypi.com \
--cc=stefan.wahren@i2se.com \
--cc=umang.jain@ideasonboard.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox