From: Lee Jones <lee@kernel.org>
To: Jeremy Kerr <jk@codeconstruct.com.au>
Cc: devicetree@vger.kernel.org, linux-kernel@vger.kernel.org,
Rob Herring <robh+dt@kernel.org>,
Krzysztof Kozlowski <krzysztof.kozlowski+dt@linaro.org>,
Arnd Bergmann <arnd@arndb.de>,
Philipp Zabel <p.zabel@pengutronix.de>,
Mark Brown <broonie@kernel.org>
Subject: Re: [PATCH v4 2/2] mfd: syscon: allow reset control for syscon devices
Date: Thu, 19 Jan 2023 16:30:16 +0000 [thread overview]
Message-ID: <Y8lwGKzWqxfQfG0j@google.com> (raw)
In-Reply-To: <20230105005010.124948-3-jk@codeconstruct.com.au>
On Thu, 05 Jan 2023, Jeremy Kerr wrote:
> Simple syscon devices may require deassertion of a reset signal in order
> to access their register set. Rather than requiring a custom driver to
> implement this, we can use the generic "resets" specifiers to link a
> reset line to the syscon.
>
> This change adds an optional reset line to the syscon device
> description, and deasserts the reset if detected.
>
> Signed-off-by: Jeremy Kerr <jk@codeconstruct.com.au>
> Reviewed-by: Arnd Bergmann <arnd@arndb.de>
>
> ---
> v2:
> * do reset control in the early of_syscon_register() path, rather than
> the platform device init, which isn't used.
> v3:
> * use a direct reset_control_deassert rather than handling in the
> regmap
> v4:
> * collapse unnecessary `else` block
> ---
> drivers/mfd/syscon.c | 27 +++++++++++++++++++++------
> 1 file changed, 21 insertions(+), 6 deletions(-)
Applied, thanks
--
Lee Jones [李琼斯]
next prev parent reply other threads:[~2023-01-20 5:34 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-01-05 0:50 [PATCH v4 0/2] Add reset control for mfd syscon devices Jeremy Kerr
2023-01-05 0:50 ` [PATCH v4 1/2] dt-bindings: mfd/syscon: Add resets property Jeremy Kerr
2023-01-19 16:29 ` Lee Jones
2023-01-05 0:50 ` [PATCH v4 2/2] mfd: syscon: allow reset control for syscon devices Jeremy Kerr
2023-01-19 16:30 ` Lee Jones [this message]
2023-09-12 21:13 ` Daniel Golle
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=Y8lwGKzWqxfQfG0j@google.com \
--to=lee@kernel.org \
--cc=arnd@arndb.de \
--cc=broonie@kernel.org \
--cc=devicetree@vger.kernel.org \
--cc=jk@codeconstruct.com.au \
--cc=krzysztof.kozlowski+dt@linaro.org \
--cc=linux-kernel@vger.kernel.org \
--cc=p.zabel@pengutronix.de \
--cc=robh+dt@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox