From: Mark Brown <broonie@kernel.org>
To: Alexandre Mergnat <amergnat@baylibre.com>
Cc: Krzysztof Kozlowski <krzysztof.kozlowski+dt@linaro.org>,
Rob Herring <robh+dt@kernel.org>,
Matthias Brugger <matthias.bgg@gmail.com>,
linux-kernel@vger.kernel.org, linux-mediatek@lists.infradead.org,
linux-spi@vger.kernel.org, devicetree@vger.kernel.org,
linux-arm-kernel@lists.infradead.org
Subject: Re: [PATCH 2/2] spi: spidev: add new mediatek support
Date: Thu, 19 Jan 2023 16:39:21 +0000 [thread overview]
Message-ID: <Y8lyORTrfmwIzEEO@sirena.org.uk> (raw)
In-Reply-To: <20230118-mt8365-spi-support-v1-2-842a21e50494@baylibre.com>
[-- Attachment #1: Type: text/plain, Size: 804 bytes --]
On Thu, Jan 19, 2023 at 05:28:50PM +0100, Alexandre Mergnat wrote:
> Add the "mediatek,genio" compatible string to support Mediatek
> SPI controller on the genio boards.
> { .compatible = "cisco,spi-petra", .data = &spidev_of_check },
> { .compatible = "micron,spi-authenta", .data = &spidev_of_check },
> + { .compatible = "mediatek,genio", .data = &spidev_of_check },
We need a matching update to the binding document.
This does also seem like a terribly generic name - Google
suggests that this is actually a series of numbered products (eg,
Genio 700), perhaps we should be using the specific numbers here?
I guess users would care which they're talking to. It really
parses as being "generic I/O" which would be an end run around
describing the actual product though it's not actually that.
[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 488 bytes --]
next prev parent reply other threads:[~2023-01-20 5:04 UTC|newest]
Thread overview: 18+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-01-19 16:28 [PATCH 0/2] Add MediaTek MT8365 SPI support Alexandre Mergnat
2023-01-19 16:28 ` [PATCH 1/2] arm64: dts: mediatek: add spidev support for mt8365-evk board Alexandre Mergnat
2023-01-19 16:28 ` [PATCH 2/2] spi: spidev: add new mediatek support Alexandre Mergnat
2023-01-19 16:39 ` Mark Brown [this message]
2023-01-19 16:40 ` Matthias Brugger
2023-01-19 16:49 ` Krzysztof Kozlowski
2023-01-19 19:18 ` Alexandre Mergnat
2023-01-20 7:44 ` Krzysztof Kozlowski
2023-01-20 7:58 ` Krzysztof Kozlowski
2023-01-20 7:47 ` Krzysztof Kozlowski
2023-01-23 10:06 ` Alexandre Mergnat
2023-01-23 15:55 ` Krzysztof Kozlowski
2023-01-20 8:20 ` Michael Walle
2023-01-23 9:37 ` Alexandre Mergnat
2023-01-23 10:44 ` Michael Walle
2023-01-23 14:57 ` Alexandre Mergnat
2023-01-23 12:19 ` Mark Brown
2023-01-23 15:07 ` Alexandre Mergnat
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=Y8lyORTrfmwIzEEO@sirena.org.uk \
--to=broonie@kernel.org \
--cc=amergnat@baylibre.com \
--cc=devicetree@vger.kernel.org \
--cc=krzysztof.kozlowski+dt@linaro.org \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-mediatek@lists.infradead.org \
--cc=linux-spi@vger.kernel.org \
--cc=matthias.bgg@gmail.com \
--cc=robh+dt@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox