public inbox for linux-kernel@vger.kernel.org
 help / color / mirror / Atom feed
From: Ashok Raj <ashok.raj@intel.com>
To: "Luck, Tony" <tony.luck@intel.com>
Cc: Borislav Petkov <bp@alien8.de>,
	"Hansen, Dave" <dave.hansen@intel.com>,
	Thomas Gleixner <tglx@linutronix.de>, X86-kernel <x86@kernel.org>,
	"LKML Mailing List" <linux-kernel@vger.kernel.org>,
	Ingo Molnar <mingo@kernel.org>,
	"Schofield, Alison" <alison.schofield@intel.com>,
	"Chatre, Reinette" <reinette.chatre@intel.com>,
	Tom Lendacky <thomas.lendacky@amd.com>,
	"Ashok Raj" <ashok.raj@intel.com>,
	David Woodhouse <dwmw2@infradead.org>, <mpohlack@amazon.de>
Subject: Re: [PATCH v4 6/6] x86/microcode/intel: Print when early microcode loading fails
Date: Thu, 19 Jan 2023 09:59:33 -0800	[thread overview]
Message-ID: <Y8mFBbWmpGvZy9dB@a4bf019067fa.jf.intel.com> (raw)
In-Reply-To: <IA1PR11MB6076660471E9C688E79A2B20FCC69@IA1PR11MB6076.namprd11.prod.outlook.com>

Hi Boris,

On Tue, Jan 17, 2023 at 12:58:12PM -0800, Tony Luck wrote:
> > If there is no microcode, we don't print anything. So what's loaded in the
> > CPU is the latest version. When we have something we can always tell if its
> > successful or not.
> >
> > Its not a microcode file in initrd, but a matching microcode to load. If
> > none is found, nothing to worry about.
> >
> > We just agreed to show both failed and success for late-load. Doing this is
> > consistent with that isn't it?
> >
> > https://lore.kernel.org/lkml/Y7iYLbEJSYnVn+dW@zn.tnic/
> >
> > Ingo's:
> > https://lore.kernel.org/lkml/Y7k9DNz%2F%2FvqBAvZK@gmail.com/
> >
> > Should we treat early loading differently?
> 
> Getting a better set of messages from early microcode update would
> be a "nice-to-have" feature. But if there is no agreement on what those
> messages should look like, perhaps just skip this part for now.
> 
> Then Ashok can move on to the real issue of allowing LATE_LOAD for a
> microcode that supports the new "minrev" header field.
> 
If this is the one blocking this series, as Tony proposed, its not worth
loosing sleep over this.

Would you recommend resubmitting a new set with the fixes for the interim
patch compile failures (for 32bit) and drop this last patch?

If you have any other comments would be great to hear now before I repost a
new series to capture everything that's need to be addressed.

As always you can change commit logs to your satisfaction, I try, but its
still not as perfect as how you like to see them.

Cheers,
Ashok

  reply	other threads:[~2023-01-20  4:59 UTC|newest]

Thread overview: 30+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2023-01-09 15:35 [PATCH v4 0/6] Some fixes and cleanups for microcode Ashok Raj
2023-01-09 15:35 ` [PATCH v4 1/6] x86/microcode: Add a parameter to microcode_check() to store CPU capabilities Ashok Raj
2023-01-21 14:54   ` [tip: x86/microcode] " tip-bot2 for Ashok Raj
2023-01-09 15:35 ` [PATCH v4 2/6] x86/microcode/core: Take a snapshot before and after applying microcode Ashok Raj
2023-01-21 14:54   ` [tip: x86/microcode] x86/microcode: Check CPU capabilities after late microcode update correctly tip-bot2 for Ashok Raj
2023-01-09 15:35 ` [PATCH v4 3/6] x86/microcode: Display revisions only when update is successful Ashok Raj
2023-01-09 15:35 ` [PATCH v4 4/6] x86/microcode/intel: Use a plain revision argument for print_ucode_rev() Ashok Raj
2023-01-15 19:25   ` Borislav Petkov
2023-01-15 19:39   ` Borislav Petkov
2023-01-17 16:05     ` Ashok Raj
2023-01-17 18:16       ` Borislav Petkov
2023-01-09 15:35 ` [PATCH v4 5/6] x86/microcode/intel: Print old and new rev during early boot Ashok Raj
2023-01-09 15:35 ` [PATCH v4 6/6] x86/microcode/intel: Print when early microcode loading fails Ashok Raj
2023-01-15 19:05   ` Borislav Petkov
2023-01-17 16:12     ` Ashok Raj
2023-01-17 16:29       ` Dave Hansen
2023-01-17 18:21         ` Borislav Petkov
2023-01-17 18:32           ` Dave Hansen
2023-01-17 18:40             ` Borislav Petkov
2023-01-17 20:40               ` Ashok Raj
2023-01-17 20:58                 ` Luck, Tony
2023-01-19 17:59                   ` Ashok Raj [this message]
2023-01-20 12:03                     ` Borislav Petkov
2023-01-20 16:52                       ` Ashok Raj
2023-01-17 21:00                 ` Dave Hansen
2023-01-17 21:06                 ` Borislav Petkov
2023-01-17 21:34                   ` Ashok Raj
2023-01-17 19:10             ` Ashok Raj
2023-01-17 16:35   ` Dave Hansen
2023-01-17 17:59     ` Ashok Raj

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=Y8mFBbWmpGvZy9dB@a4bf019067fa.jf.intel.com \
    --to=ashok.raj@intel.com \
    --cc=alison.schofield@intel.com \
    --cc=bp@alien8.de \
    --cc=dave.hansen@intel.com \
    --cc=dwmw2@infradead.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=mingo@kernel.org \
    --cc=mpohlack@amazon.de \
    --cc=reinette.chatre@intel.com \
    --cc=tglx@linutronix.de \
    --cc=thomas.lendacky@amd.com \
    --cc=tony.luck@intel.com \
    --cc=x86@kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox