From: Conor Dooley <conor@kernel.org>
To: Jisheng Zhang <jszhang@kernel.org>
Cc: Paul Walmsley <paul.walmsley@sifive.com>,
Palmer Dabbelt <palmer@dabbelt.com>,
Albert Ou <aou@eecs.berkeley.edu>,
Masahiro Yamada <masahiroy@kernel.org>,
Kees Cook <keescook@chromium.org>,
Nathan Chancellor <nathan@kernel.org>,
linux-riscv@lists.infradead.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH v2 1/5] riscv: lds: define RUNTIME_DISCARD_EXIT
Date: Thu, 19 Jan 2023 18:32:11 +0000 [thread overview]
Message-ID: <Y8mMqxqegQ5XThKv@spud> (raw)
In-Reply-To: <20230119155417.2600-2-jszhang@kernel.org>
[-- Attachment #1: Type: text/plain, Size: 759 bytes --]
On Thu, Jan 19, 2023 at 11:54:13PM +0800, Jisheng Zhang wrote:
> riscv discards .exit.* sections at run-time but doesn't define
> RUNTIME_DISCARD_EXIT. However, the .exit.* sections are still allocated
> and kept even if the generic DISCARDS would discard the sections due
> to missing RUNTIME_DISCARD_EXIT, because the DISCARD sits at the end of
> the linker script. Add the missing RUNTIME_DISCARD_EXIT define so that
> it still works if we move DISCARD up or even at the beginning of the
> linker script.
>
> Signed-off-by: Jisheng Zhang <jszhang@kernel.org>
> Suggested-by: Masahiro Yamada <masahiroy@kernel.org>
Thought I left one of these against v1, either way:
Reviewed-by: Conor Dooley <conor.dooley@microchip.com>
Thanks,
Conor.
[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 228 bytes --]
next prev parent reply other threads:[~2023-01-20 5:20 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-01-19 15:54 [PATCH v2 0/5] riscv: improve link and support ARCH_WANT_LD_ORPHAN_WARN Jisheng Zhang
2023-01-19 15:54 ` [PATCH v2 1/5] riscv: lds: define RUNTIME_DISCARD_EXIT Jisheng Zhang
2023-01-19 18:32 ` Conor Dooley [this message]
2023-01-19 15:54 ` [PATCH v2 2/5] riscv: vmlinux.lds.S: explicitly catch .rela.dyn symbols Jisheng Zhang
2023-01-19 15:54 ` [PATCH v2 3/5] riscv: vmlinux.lds.S: explicitly catch .riscv.attributes sections Jisheng Zhang
2023-01-19 15:54 ` [PATCH v2 4/5] riscv: vmlinux.lds.S: explicitly catch .init.bss sections from EFI stub Jisheng Zhang
2023-01-19 15:54 ` [PATCH v2 5/5] riscv: select ARCH_WANT_LD_ORPHAN_WARN for !XIP_KERNEL Jisheng Zhang
2023-01-20 8:06 ` Conor Dooley
2023-02-22 15:00 ` [PATCH v2 0/5] riscv: improve link and support ARCH_WANT_LD_ORPHAN_WARN patchwork-bot+linux-riscv
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=Y8mMqxqegQ5XThKv@spud \
--to=conor@kernel.org \
--cc=aou@eecs.berkeley.edu \
--cc=jszhang@kernel.org \
--cc=keescook@chromium.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-riscv@lists.infradead.org \
--cc=masahiroy@kernel.org \
--cc=nathan@kernel.org \
--cc=palmer@dabbelt.com \
--cc=paul.walmsley@sifive.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox