From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id 5371AC678DC for ; Fri, 20 Jan 2023 04:50:16 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S229730AbjATEuO (ORCPT ); Thu, 19 Jan 2023 23:50:14 -0500 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:40672 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S229722AbjATEtb (ORCPT ); Thu, 19 Jan 2023 23:49:31 -0500 Received: from ams.source.kernel.org (ams.source.kernel.org [IPv6:2604:1380:4601:e00::1]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 72567D0DAC for ; Thu, 19 Jan 2023 20:43:24 -0800 (PST) Received: from smtp.kernel.org (relay.kernel.org [52.25.139.140]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by ams.source.kernel.org (Postfix) with ESMTPS id BB80EB826A5 for ; Thu, 19 Jan 2023 20:57:49 +0000 (UTC) Received: by smtp.kernel.org (Postfix) with ESMTPSA id 390CAC43392; Thu, 19 Jan 2023 20:57:46 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1674161868; bh=agbUGJOpRM48rXjHCnwA0EWMxXQAmOrokiPjNj8tXRs=; h=Date:From:To:Cc:Subject:References:In-Reply-To:From; b=IMDM8X+JGhZrv40FDVi+Xbq0y1BMxv0941edpqsV0rEmE8eYs967IORb/ws2qfW4Z R2CJ6PdhcTa+CGHxTmu1NiN1T/RaNwsR3jl3JN/YmBU4ZKt62JCrkBlq06/rQ2lMSa xBABvLhST286HTqtB+a8aKvyWWCIq3TPXLujncdDNm2znEu4+DTR3MQVRLOBcMGB2a SHSwYaM+UzGZGSuy3Tv1GKI8FRQLyKdZwfEJlXpe7szWlyoWOO5YwyD4CQVmfWvALG cHY1Ha6TSSNbao3gOMj86Sw2GD8IbfhoiL0LpD1A4FrNLpyStGlmy5zRiN8dwQs9Jy iANi6PDomCr9w== Date: Thu, 19 Jan 2023 20:57:43 +0000 From: Lee Jones To: Liang He Cc: ckeepax@opensource.cirrus.com, patches@opensource.cirrus.com, linux-kernel@vger.kernel.org Subject: Re: [PATCH v2] mfd: arizona: Use pm_runtime_resume_and_get() to prevent refcnt leak Message-ID: References: <20230105061055.1509261-1-windhl@126.com> MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Disposition: inline Content-Transfer-Encoding: 8bit In-Reply-To: <20230105061055.1509261-1-windhl@126.com> Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Thu, 05 Jan 2023, Liang He wrote: > In arizona_clk32k_enable(), we should use pm_runtime_resume_and_get() > as pm_runtime_get_sync() will increase the refcnt even when it > returns an error. > > Signed-off-by: Liang He > --- > changelog: > v1: add missing pm_runtime_put_sync() > v2: use pm_runtime_resume_and_get() > > drivers/mfd/arizona-core.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) Applied, thanks -- Lee Jones [李琼斯]