From: Conor Dooley <conor.dooley@microchip.com>
To: Jesse Taube <mr.bossman075@gmail.com>
Cc: <linux-riscv@lists.infradead.org>, <linux-kernel@vger.kernel.org>,
Yimin Gu <ustcymgu@gmail.com>,
Waldemar Brodkorb <wbx@openadk.org>,
Albert Ou <aou@eecs.berkeley.edu>,
Palmer Dabbelt <palmer@dabbelt.com>,
Paul Walmsley <paul.walmsley@sifive.com>
Subject: Re: [PATCH v1 1/2] riscv: Kconfig: Allow RV32 to build with no MMU
Date: Fri, 20 Jan 2023 07:59:31 +0000 [thread overview]
Message-ID: <Y8pJ4y7FyBDQPqIT@wendy> (raw)
In-Reply-To: <20230119052642.1112171-2-Mr.Bossman075@gmail.com>
[-- Attachment #1: Type: text/plain, Size: 1560 bytes --]
Hello!
Since you'll have to re-submit, making sure that allowing !MMU on rv32
doesn't break the build due to canaan k210 drivers being enabled despite
relying on 64-bit divisions, I've got some nits for you.
On Thu, Jan 19, 2023 at 12:26:41AM -0500, Jesse Taube wrote:
> From: Yimin Gu <ustcymgu@gmail.com>
>
> Some RISC-V 32bit ores do not have an MMU, and the kernel should be
s/ores/cores
> able to build for them. This patch enables the RV32 to be built with
> no MMU support.
>
> Signed-off-by: Yimin Gu <ustcymgu@gmail.com>
> CC: Jesse Taube <Mr.Bossman075@gmail.com>
> Tested-By: Waldemar Brodkorb <wbx@openadk.org>
And the automation complains that this tag is not "Tested-by:"
Thanks,
Conor.
> Signed-off-by: Jesse Taube <Mr.Bossman075@gmail.com>
> ---
> arch/riscv/Kconfig | 5 ++---
> 1 file changed, 2 insertions(+), 3 deletions(-)
>
> diff --git a/arch/riscv/Kconfig b/arch/riscv/Kconfig
> index 59d18881f35b..49759dbe6a8f 100644
> --- a/arch/riscv/Kconfig
> +++ b/arch/riscv/Kconfig
> @@ -163,8 +163,8 @@ config MMU
>
> config PAGE_OFFSET
> hex
> - default 0xC0000000 if 32BIT
> - default 0x80000000 if 64BIT && !MMU
> + default 0xC0000000 if 32BIT && MMU
> + default 0x80000000 if !MMU
> default 0xff60000000000000 if 64BIT
>
> config KASAN_SHADOW_OFFSET
> @@ -262,7 +262,6 @@ config ARCH_RV32I
> select GENERIC_LIB_ASHRDI3
> select GENERIC_LIB_LSHRDI3
> select GENERIC_LIB_UCMPDI2
> - select MMU
>
> config ARCH_RV64I
> bool "RV64I"
> --
> 2.39.0
>
>
[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 228 bytes --]
next prev parent reply other threads:[~2023-01-20 8:00 UTC|newest]
Thread overview: 12+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-01-19 5:26 [PATCH v1 0/2] Add RISC-V 32 NOMMU support Jesse Taube
2023-01-19 5:26 ` [PATCH v1 1/2] riscv: Kconfig: Allow RV32 to build with no MMU Jesse Taube
2023-01-20 7:33 ` kernel test robot
2023-01-20 7:59 ` Conor Dooley [this message]
2023-01-20 17:39 ` Jesse Taube
2023-01-20 20:44 ` Conor Dooley
2023-01-20 20:48 ` Conor Dooley
2023-01-20 20:51 ` Jesse Taube
2023-01-20 20:57 ` Conor Dooley
2023-01-21 15:00 ` Conor Dooley
2023-01-19 5:26 ` [PATCH v1 2/2] riscv: configs: Add nommu decfconfig for RV32 Jesse Taube
2023-01-20 8:05 ` Conor Dooley
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=Y8pJ4y7FyBDQPqIT@wendy \
--to=conor.dooley@microchip.com \
--cc=aou@eecs.berkeley.edu \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-riscv@lists.infradead.org \
--cc=mr.bossman075@gmail.com \
--cc=palmer@dabbelt.com \
--cc=paul.walmsley@sifive.com \
--cc=ustcymgu@gmail.com \
--cc=wbx@openadk.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox