From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id BDCFBC27C7C for ; Fri, 20 Jan 2023 14:10:11 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S230178AbjATOKK (ORCPT ); Fri, 20 Jan 2023 09:10:10 -0500 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:36632 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S230163AbjATOKH (ORCPT ); Fri, 20 Jan 2023 09:10:07 -0500 Received: from esa.microchip.iphmx.com (esa.microchip.iphmx.com [68.232.153.233]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id C11B9BCE0D; Fri, 20 Jan 2023 06:10:04 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=microchip.com; i=@microchip.com; q=dns/txt; s=mchp; t=1674223805; x=1705759805; h=date:from:to:cc:subject:message-id:references: mime-version:in-reply-to; bh=yWdP0AlkpNuGpE4SWfbgyApq7EB/xPrL4Lku7qnnWiI=; b=vcVeDV03uW4jBT+v0wztj1di2i53v/ERMz1mGOxh9tueGjzqb3XnlMSS KDdOB4m0mKgn5u5gZ+muXljd0P85356Tt57lTCvDLP8tgDsX/8B74G6jD TFcSaJLeGjZSMJZ/tmLSvpIXYJVrgPcWiUm/zZlXObjt/rVcuqvzg4iS1 CVHYU2Suj7Dhaq1dKYdbxlcw5dAnbM89QR73o8TPyvnMoK6L+NE70qI6r D7mjwCsxMcatlyngVRTlf7hEgk4XfpzDSF9S7RmGbumrZnYKlWtCVYqgX t4xbMk6JxEb4IhsYgANoVk4uom/wQVwLMUW+nSliBW0wCq0GjwdecY4S+ A==; X-IronPort-AV: E=Sophos;i="5.97,232,1669100400"; d="asc'?scan'208";a="197635228" Received: from unknown (HELO email.microchip.com) ([170.129.1.10]) by esa5.microchip.iphmx.com with ESMTP/TLS/AES256-SHA256; 20 Jan 2023 07:10:05 -0700 Received: from chn-vm-ex04.mchp-main.com (10.10.85.152) by chn-vm-ex01.mchp-main.com (10.10.85.143) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2507.16; Fri, 20 Jan 2023 07:09:59 -0700 Received: from wendy (10.10.115.15) by chn-vm-ex04.mchp-main.com (10.10.85.152) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2507.16 via Frontend Transport; Fri, 20 Jan 2023 07:09:57 -0700 Date: Fri, 20 Jan 2023 14:09:35 +0000 From: Conor Dooley To: Prabhakar CC: Paul Walmsley , Palmer Dabbelt , Albert Ou , Daniel Lezcano , Thomas Gleixner , , Geert Uytterhoeven , , , Lad Prabhakar , Samuel Holland Subject: Re: [PATCH v2] clocksource/drivers/riscv: Get rid of clocksource_arch_init() callback Message-ID: References: <20221229224601.103851-1-prabhakar.mahadev-lad.rj@bp.renesas.com> MIME-Version: 1.0 Content-Type: multipart/signed; micalg=pgp-sha256; protocol="application/pgp-signature"; boundary="jF0mOp7nLO7/TrvI" Content-Disposition: inline In-Reply-To: <20221229224601.103851-1-prabhakar.mahadev-lad.rj@bp.renesas.com> Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org --jF0mOp7nLO7/TrvI Content-Type: text/plain; charset=us-ascii Content-Disposition: inline Content-Transfer-Encoding: quoted-printable On Thu, Dec 29, 2022 at 10:46:01PM +0000, Prabhakar wrote: > From: Lad Prabhakar >=20 > Having a clocksource_arch_init() callback always sets vdso_clock_mode to > VDSO_CLOCKMODE_ARCHTIMER if GENERIC_GETTIMEOFDAY is enabled, this is > required for the riscv-timer. >=20 > This works for platforms where just riscv-timer clocksource is present. > On platforms where other clock sources are available we want them to > register with vdso_clock_mode set to VDSO_CLOCKMODE_NONE. >=20 > On the Renesas RZ/Five SoC OSTM block can be used as clocksource [0], to > avoid multiple clock sources being registered as VDSO_CLOCKMODE_ARCHTIMER > move setting of vdso_clock_mode in the riscv-timer driver instead of doing > this in clocksource_arch_init() callback as done similarly for ARM/64 > architecture. >=20 > [0] drivers/clocksource/renesas-ostm.c >=20 > Signed-off-by: Lad Prabhakar > Tested-by: Samuel Holland > --- > RFC -> v2 > * Dropped vdso_default static global variable > * Used IS_ENABLED() macro Not sure it really makes much difference here either way, but increased coverage is always good I suppose. rv32 is the user for the !GENERIC_GETTIMEOFDAY patch IIRC and nothing seemed obviously amiss there to me either. Reviewed-by: Conor Dooley --jF0mOp7nLO7/TrvI Content-Type: application/pgp-signature; name="signature.asc" -----BEGIN PGP SIGNATURE----- iHUEABYIAB0WIQRh246EGq/8RLhDjO14tDGHoIJi0gUCY8qgngAKCRB4tDGHoIJi 0lANAP4/lQXHQYV12FWR9fMBrlqGro7dG6zJw5CN12H3WufHkAEA+pjrHts9eaEc DyDNhC86lie/e9gho75+rDX39f81DgQ= =ZdMu -----END PGP SIGNATURE----- --jF0mOp7nLO7/TrvI--