From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id 1DDD4C25B4E for ; Fri, 20 Jan 2023 14:35:12 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S230422AbjATOfL (ORCPT ); Fri, 20 Jan 2023 09:35:11 -0500 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:37930 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S229770AbjATOfI (ORCPT ); Fri, 20 Jan 2023 09:35:08 -0500 Received: from foss.arm.com (foss.arm.com [217.140.110.172]) by lindbergh.monkeyblade.net (Postfix) with ESMTP id 1C9F172C36; Fri, 20 Jan 2023 06:34:47 -0800 (PST) Received: from usa-sjc-imap-foss1.foss.arm.com (unknown [10.121.207.14]) by usa-sjc-mx-foss1.foss.arm.com (Postfix) with ESMTP id 7092C14BF; Fri, 20 Jan 2023 06:35:28 -0800 (PST) Received: from e120937-lin (unknown [172.31.20.19]) by usa-sjc-imap-foss1.foss.arm.com (Postfix) with ESMTPSA id E6CE53F67D; Fri, 20 Jan 2023 06:34:45 -0800 (PST) Date: Fri, 20 Jan 2023 14:34:39 +0000 From: Cristian Marussi To: Bagas Sanjaya Cc: linux-kernel@vger.kernel.org, linux-arm-kernel@lists.infradead.org, Linux Documentation , sudeep.holla@arm.com, Vincent Guittot Subject: Re: [PATCH] firmware: arm_scmi: Clarify Raw per-channel ABI documentation Message-ID: References: <20230120122326.1932614-1-cristian.marussi@arm.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Fri, Jan 20, 2023 at 07:43:30PM +0700, Bagas Sanjaya wrote: > [Also Cc: linux-doc list] > Sorry for missing the Cc but get_maintainer.pl did not say anything about this ABI docs patches. > On Fri, Jan 20, 2023 at 12:23:26PM +0000, Cristian Marussi wrote: > > diff --git a/Documentation/ABI/testing/debugfs-scmi-raw b/Documentation/ABI/testing/debugfs-scmi-raw > > index 5468ec08c084..b1c505ed444c 100644 > > --- a/Documentation/ABI/testing/debugfs-scmi-raw > > +++ b/Documentation/ABI/testing/debugfs-scmi-raw > > @@ -80,9 +80,13 @@ Description: SCMI Raw synchronous message injection/snooping facility; write > > Each write to the entry causes one command request to be built > > and sent while the replies are read back one message at time > > (receiving an EOF at each message boundary). > > + Channel identifier matches the SCMI protocol number which > > + has been associated with this transport channel in the DT > > + description, with Base protocol number 0x10 being the default > > + channel for this instance. > > s/Base/base/ > Thought that being an SCMI protocol name definitions would have to be capitalized. > > Note that these per-channel entries rooted at <..>/channels > > exist only if the transport is configured to have more than > > - one channel. > > + one default channel. > > Users: Debugging, any userspace test suite > > > > What: /sys/kernel/debug/scmi//raw/channels//message_async > > @@ -103,7 +107,11 @@ Description: SCMI Raw asynchronous message injection/snooping facility; write > > Each write to the entry causes one command request to be built > > and sent while the replies are read back one message at time > > (receiving an EOF at each message boundary). > > + Channel identifier matches the SCMI protocol number which > > + has been associated with this transport channel in the DT > > + description, with Base protocol number 0x10 being the default > > + channel for this instance. > > Same here. > > > Note that these per-channel entries rooted at <..>/channels > > exist only if the transport is configured to have more than > > - one channel. > > + one default channel. > > Users: Debugging, any userspace test suite > > Otherwise LGTM. > Thanks, Cristian