From: Al Viro <viro@zeniv.linux.org.uk>
To: Ira Weiny <ira.weiny@intel.com>
Cc: Helge Deller <deller@gmx.de>,
Matthew Wilcox <willy@infradead.org>,
"Fabio M. De Francesco" <fmdefrancesco@gmail.com>,
Christoph Hellwig <hch@infradead.org>,
linux-kernel@vger.kernel.org, linux-fsdevel@vger.kernel.org,
linux-parisc@vger.kernel.org
Subject: Re: [PATCH v3 4/4] fs/sysv: Replace kmap() with kmap_local_page()
Date: Sat, 21 Jan 2023 19:26:56 +0000 [thread overview]
Message-ID: <Y8w8gJZBCNqKaYXs@ZenIV> (raw)
In-Reply-To: <63cb9ce63db7e_c68ad29473@iweiny-mobl.notmuch>
On Sat, Jan 21, 2023 at 12:05:58AM -0800, Ira Weiny wrote:
> First, arn't PAGE_ALIGN_DOWN(addr) and PTR_ALIGN_DOWN(addr, PAGE_SIZE) the
> same?
>
> align.h
> #define PTR_ALIGN_DOWN(p, a) ((typeof(p))ALIGN_DOWN((unsigned long)(p), (a)))
>
> mm.h:
> #define PAGE_ALIGN_DOWN(addr) ALIGN_DOWN(addr, PAGE_SIZE)
... and ALIGN_DOWN ends up with doing bitwise and on the first argument.
Which doesn't work for pointers, thus the separate variant for those
and typecast to unsigned long in it...
next prev parent reply other threads:[~2023-01-21 19:28 UTC|newest]
Thread overview: 19+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-01-19 15:32 [PATCH v3 0/4] fs/sysv: Replace kmap() with kmap_local_page() Fabio M. De Francesco
2023-01-19 15:32 ` [PATCH v3 1/4] fs/sysv: Use the offset_in_page() helper Fabio M. De Francesco
2023-01-19 15:32 ` [PATCH v3 2/4] fs/sysv: Change the signature of dir_get_page() Fabio M. De Francesco
2023-01-19 15:32 ` [PATCH v3 3/4] fs/sysv: Use dir_put_page() in sysv_rename() Fabio M. De Francesco
2023-01-19 15:32 ` [PATCH v3 4/4] fs/sysv: Replace kmap() with kmap_local_page() Fabio M. De Francesco
2023-01-20 0:54 ` Al Viro
2023-01-20 4:21 ` Al Viro
2023-01-20 4:28 ` Matthew Wilcox
2023-01-20 4:45 ` Al Viro
2023-01-20 4:54 ` Matthew Wilcox
2023-01-20 5:07 ` Al Viro
2023-01-20 5:56 ` Al Viro
2023-01-20 7:17 ` Helge Deller
2023-01-21 8:05 ` Ira Weiny
2023-01-21 10:57 ` Helge Deller
2023-01-21 19:26 ` Al Viro [this message]
2023-01-23 17:14 ` Fabio M. De Francesco
2023-01-24 20:16 ` Ira Weiny
2023-01-23 17:03 ` Fabio M. De Francesco
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=Y8w8gJZBCNqKaYXs@ZenIV \
--to=viro@zeniv.linux.org.uk \
--cc=deller@gmx.de \
--cc=fmdefrancesco@gmail.com \
--cc=hch@infradead.org \
--cc=ira.weiny@intel.com \
--cc=linux-fsdevel@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-parisc@vger.kernel.org \
--cc=willy@infradead.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox