From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id 046A6C25B50 for ; Sat, 21 Jan 2023 17:59:07 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S229864AbjAUR7G (ORCPT ); Sat, 21 Jan 2023 12:59:06 -0500 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:33536 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S229769AbjAUR7D (ORCPT ); Sat, 21 Jan 2023 12:59:03 -0500 Received: from metanate.com (unknown [IPv6:2001:8b0:1628:5005::111]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 7151EB46A for ; Sat, 21 Jan 2023 09:58:34 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=metanate.com; s=stronger; h=In-Reply-To:Content-Type:References:Message-ID: Subject:Cc:To:From:Date:Reply-To:Content-Transfer-Encoding:Content-ID: Content-Description; bh=EUyECha8HaxVxgq1F1KoFMr1DGt4Ij3T1L3mz8LljAM=; b=1MAQ0 3rGGQF+HQYx+iCsXN4SYOL1zEHCSG4P0IMdvNTbjw/ou4gvoaCnWEAf7Ii1Xqjrj2CxtM0KAa0qtO 6xzlg7iPuMMlh4GDH2X8oIOEfg1R0qjdAQtqAKxvnFWxl35Jgyfur1jFsBeiBSv1e523z8ERWsDHk 0xs7/I2CiPAjoBzo+QjTXQnIjvrEar62l3ifB6KZ9VbKEIJWwGkm2sEULdLyFY4asptqb0F+zoK9A hez1cbWN3HmBCfjbqPAJFvbGTnvvzapYWS9J0gPoCCwyNkvhd1Er7UCUB+OVTj9ost81ArzpfJ+dt t37w7Tr11kn6TjSQj9hQj+rjsFfOA==; Received: from [81.174.171.191] (helo=donbot) by email.metanate.com with esmtpsa (TLS1.3) tls TLS_AES_256_GCM_SHA384 (Exim 4.95) (envelope-from ) id 1pJI8A-0004Ik-P2; Sat, 21 Jan 2023 17:58:18 +0000 Date: Sat, 21 Jan 2023 17:58:11 +0000 From: John Keeping To: Sam Ravnborg Cc: Doug Anderson , Neil Armstrong , Jernej Skrabec , Robert Foss , Jonas Karlman , linux-kernel@vger.kernel.org, dri-devel@lists.freedesktop.org, Stephen Boyd , Laurent Pinchart , Andrzej Hajda , Hsin-Yi Wang Subject: Re: [PATCH] drm/bridge: panel: Set orientation on panel_bridge connector Message-ID: References: <20230120114313.2087015-1-john@metanate.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: X-Authenticated: YES Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Hi Sam & Doug, On Sat, Jan 21, 2023 at 09:57:18AM +0100, Sam Ravnborg wrote: > On Fri, Jan 20, 2023 at 01:44:38PM -0800, Doug Anderson wrote: > > On Fri, Jan 20, 2023 at 3:43 AM John Keeping wrote: > > > > > > Commit 15b9ca1641f0 ("drm: Config orientation property if panel provides > > > it") added a helper to set the panel panel orientation early but only > > > connected this for drm_bridge_connector, which constructs a panel bridge > > > with DRM_BRIDGE_ATTACH_NO_CONNECTOR and creates the connector itself. > > > > > > When the DRM_BRIDGE_ATTACH_NO_CONNECTOR flag is not specified and the > > > panel_bridge creates its own connector the orientation is not set unless > > > the panel does it in .get_modes which is too late and leads to a warning > > > splat from __drm_mode_object_add() because the device is already > > > registered. > > > > > > Call the necessary function to set add the orientation property when the > > > connector is created so that it is available before the device is > > > registered. > > > > I have no huge objection to your patch and it looks OK to me. That > > being said, my understanding is that: > > > > 1. DRM_BRIDGE_ATTACH_NO_CONNECTOR is "the future" and not using the > > flag is "deprecated". > Correct. > Could we take a look at how much is required to move the relevant driver > to use DRM_BRIDGE_ATTACH_NO_CONNECTOR? > > If this is too much work now we may land this simple patch, but the > preference is to move all drivers to the new bridge handling and thus > asking display drivers to create the connector. > > What display driver are we dealing with here? This is dw-mipi-dsi-rockchip which uses the component path in dw-mipi-dsi (and, in fact, is the only driver using that mode of dw-mipi-dsi). I'm not familiar enough with DRM to say whether it's easy to convert to DRM_BRIDGE_ATTACH_NO_CONNECTOR - should dw-mipi-dsi-rockchip be moving to use dw-mipi-dsi as a bridge driver or should dw_mipi_dsi_bind() have a drm_bridge_attach_flags argument? But I'm happy to test patches if it looks easy to convert to you :-) John