Regarding checkpatch camelcase issues

Regarding checkpatch camelcase issues

[Guru Mehar Rachaputi]

Thanks for your support.

I wanted to confirm if each checkpatch encounter for camelcase issue should
be fixed in a new patch?

For example: If the issue is with same variable, then multiple
modifications can be made in one patch.

  -> above example is OK


For example: If the issue is with multiple variables, then multiple
modifications can be made in one patch.

  -> above example is NOT OK / NG


Please confirm me if my understanding is correct?

-- 
Thanks & Regards,
Guru

Re: Regarding checkpatch camelcase issues

[Bagas Sanjaya]

[-- Attachment #1: Type: text/plain, Size: 1060 bytes --]

On Sat, Feb 04, 2023 at 05:25:38AM +0100, Guru Mehar Rachaputi wrote:
> Thanks for your support.
> 
> I wanted to confirm if each checkpatch encounter for camelcase issue should
> be fixed in a new patch?
> 
> For example: If the issue is with same variable, then multiple
> modifications can be made in one patch.
> 
>   -> above example is OK
> 
> 
> For example: If the issue is with multiple variables, then multiple
> modifications can be made in one patch.
> 
>   -> above example is NOT OK / NG
> 
> 
> Please confirm me if my understanding is correct?
> 

I guess you have generated a patch series, then check it through
checkpatch.

Indeed, if checkpatch complains at a particular patch, you need to do
interactive rebase. Make sure that rebase todo list contains "edit"
lines on commit you want to fix up. After that, fix these complaints.

When you're done, regenerate the patch series and make sure that there
are no checkpatch complains on it.

Thanks.

-- 
An old man doll... just what I always wanted! - Clara

[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 228 bytes --]

Re: Regarding checkpatch camelcase issues

[Guru Mehar Rachaputi]

On Sat, Feb 04, 2023 at 02:40:41PM +0700, Bagas Sanjaya wrote:
> On Sat, Feb 04, 2023 at 05:25:38AM +0100, Guru Mehar Rachaputi wrote:
> > Thanks for your support.
> > 
> > I wanted to confirm if each checkpatch encounter for camelcase issue should
> > be fixed in a new patch?
> > 
> > For example: If the issue is with same variable, then multiple
> > modifications can be made in one patch.
> > 
> >   -> above example is OK
> > 
> > 
> > For example: If the issue is with multiple variables, then multiple
> > modifications can be made in one patch.
> > 
> >   -> above example is NOT OK / NG
> > 
> > 
> > Please confirm me if my understanding is correct?
> > 
> 
> I guess you have generated a patch series, then check it through
> checkpatch.
> 
> Indeed, if checkpatch complains at a particular patch, you need to do
> interactive rebase. Make sure that rebase todo list contains "edit"
> lines on commit you want to fix up. After that, fix these complaints.
> 
> When you're done, regenerate the patch series and make sure that there
> are no checkpatch complains on it.
> 
> Thanks.
> 
> -- 
> An old man doll... just what I always wanted! - Clara

Thanks for the reply
I guess I was not clear. When I run checkpatch on a driver there
were so many camelcase issues in each file. So I wanted to know if I
proceed to fix them, should I submit each change as a patch or each file
as a patch?
Since each file has many camelcase issue and the driver has morethan one
such file.

-- 
Thanks & Regards,
Guru

Re: Regarding checkpatch camelcase issues

[Deepak R Varma]

On Sun, Feb 05, 2023 at 12:46:25AM +0100, Guru Mehar Rachaputi wrote:
> On Sat, Feb 04, 2023 at 02:40:41PM +0700, Bagas Sanjaya wrote:
> > On Sat, Feb 04, 2023 at 05:25:38AM +0100, Guru Mehar Rachaputi wrote:
> > > Thanks for your support.
> > > 
> > > I wanted to confirm if each checkpatch encounter for camelcase issue should
> > > be fixed in a new patch?
> > > 
> > > For example: If the issue is with same variable, then multiple
> > > modifications can be made in one patch.
> > > 
> > >   -> above example is OK
> > > 
> > > 
> > > For example: If the issue is with multiple variables, then multiple
> > > modifications can be made in one patch.
> > > 
> > >   -> above example is NOT OK / NG
> > > 
> > > 
> > > Please confirm me if my understanding is correct?
> > > 
> > 
> > I guess you have generated a patch series, then check it through
> > checkpatch.
> > 
> > Indeed, if checkpatch complains at a particular patch, you need to do
> > interactive rebase. Make sure that rebase todo list contains "edit"
> > lines on commit you want to fix up. After that, fix these complaints.
> > 
> > When you're done, regenerate the patch series and make sure that there
> > are no checkpatch complains on it.
> > 
> > Thanks.
> > 
> > -- 
> > An old man doll... just what I always wanted! - Clara
> 
> Thanks for the reply
> I guess I was not clear. When I run checkpatch on a driver there
> were so many camelcase issues in each file. So I wanted to know if I
> proceed to fix them, should I submit each change as a patch or each file
> as a patch?
> Since each file has many camelcase issue and the driver has morethan one
> such file.

Hi Guru,
You can look at similar change proposals from other developers here[1]. That should help
you understand how it was done previously. This resource is very useful to
determine if the change you are proposing was already submit by another
developer and the feedback on it. In general, it is a great resource to learn.

You should also look at the guidelines on how to design your patch, number of
changes, when to use a patch set etc at this location[2]. This page has more
additional links to resources that are useful to understand how to submit
patches. Check these links [3] & [4].


[1] https://lore.kernel.org/?q=&a=search+all+inboxes
[2] https://kernelnewbies.org/Outreachyfirstpatch
[3] https://kernelnewbies.org/PatchPhilosophy
[4] https://elixir.bootlin.com/linux/latest/source/Documentation/process/coding-style.rst

Hope this helps.

Regards,
deepak

> 
> -- 
> Thanks & Regards,
> Guru
> 

Re: Regarding checkpatch camelcase issues

[Guru Mehar Rachaputi]

On Sun, Feb 05, 2023 at 09:57:10AM +0530, Deepak R Varma wrote:
> On Sun, Feb 05, 2023 at 12:46:25AM +0100, Guru Mehar Rachaputi wrote:
> > On Sat, Feb 04, 2023 at 02:40:41PM +0700, Bagas Sanjaya wrote:
> > > On Sat, Feb 04, 2023 at 05:25:38AM +0100, Guru Mehar Rachaputi wrote:
> > > > Thanks for your support.
> > > > 
> > > > I wanted to confirm if each checkpatch encounter for camelcase issue should
> > > > be fixed in a new patch?
> > > > 
> > > > For example: If the issue is with same variable, then multiple
> > > > modifications can be made in one patch.
> > > > 
> > > >   -> above example is OK
> > > > 
> > > > 
> > > > For example: If the issue is with multiple variables, then multiple
> > > > modifications can be made in one patch.
> > > > 
> > > >   -> above example is NOT OK / NG
> > > > 
> > > > 
> > > > Please confirm me if my understanding is correct?
> > > > 
> > > 
> > > I guess you have generated a patch series, then check it through
> > > checkpatch.
> > > 
> > > Indeed, if checkpatch complains at a particular patch, you need to do
> > > interactive rebase. Make sure that rebase todo list contains "edit"
> > > lines on commit you want to fix up. After that, fix these complaints.
> > > 
> > > When you're done, regenerate the patch series and make sure that there
> > > are no checkpatch complains on it.
> > > 
> > > Thanks.
> > > 
> > > -- 
> > > An old man doll... just what I always wanted! - Clara
> > 
> > Thanks for the reply
> > I guess I was not clear. When I run checkpatch on a driver there
> > were so many camelcase issues in each file. So I wanted to know if I
> > proceed to fix them, should I submit each change as a patch or each file
> > as a patch?
> > Since each file has many camelcase issue and the driver has morethan one
> > such file.
> 
> Hi Guru,
> You can look at similar change proposals from other developers here[1]. That should help
> you understand how it was done previously. This resource is very useful to
> determine if the change you are proposing was already submit by another
> developer and the feedback on it. In general, it is a great resource to learn.
> 
> You should also look at the guidelines on how to design your patch, number of
> changes, when to use a patch set etc at this location[2]. This page has more
> additional links to resources that are useful to understand how to submit
> patches. Check these links [3] & [4].
> 
> 
> [1] https://lore.kernel.org/?q=&a=search+all+inboxes
> [2] https://kernelnewbies.org/Outreachyfirstpatch
> [3] https://kernelnewbies.org/PatchPhilosophy
> [4] https://elixir.bootlin.com/linux/latest/source/Documentation/process/coding-style.rst
> 
> Hope this helps.
> 
> Regards,
> deepak
> 
> > 
> > -- 
> > Thanks & Regards,
> > Guru
> > 
> 
> 

Thanks for the references deepak.
This should help.

-- 
Thanks & Regards,
Guru