Re: [PATCHv6 05/11] mfd: rk808: split into core and i2c

Sebastian Reichel
2023-02-05T01:06:41Z

[-- Attachment #1: Type: text/plain, Size: 1661 bytes --]

Hi Lee,

On Sat, Feb 04, 2023 at 02:01:46PM +0000, Lee Jones wrote:
> On Sat, 04 Feb 2023, Lee Jones wrote:
> > On Fri, 27 Jan 2023, Sebastian Reichel wrote:
> > > Split rk808 into a core and an i2c part in preperation for
> > > SPI support.
> > >
> > > Signed-off-by: Sebastian Reichel <sebastian.reichel@collabora.com>
> > > ---
> > > drivers/clk/Kconfig | 2 +-
> > > drivers/input/misc/Kconfig | 2 +-
> > > drivers/mfd/Kconfig | 7 +-
> > > drivers/mfd/Makefile | 3 +-
> > > drivers/mfd/{rk808.c => rk8xx-core.c} | 209 +++++---------------------
> > > drivers/mfd/rk8xx-i2c.c | 200 ++++++++++++++++++++++++
> > > drivers/pinctrl/Kconfig | 2 +-
> > > drivers/power/supply/Kconfig | 2 +-
> > > drivers/regulator/Kconfig | 2 +-
> > > drivers/rtc/Kconfig | 2 +-
> > > include/linux/mfd/rk808.h | 6 +
> > > sound/soc/codecs/Kconfig | 2 +-
> > > 12 files changed, 256 insertions(+), 183 deletions(-)
> > > rename drivers/mfd/{rk808.c => rk8xx-core.c} (76%)
> > > create mode 100644 drivers/mfd/rk8xx-i2c.c
> >
> > Looks like you completely ignored (no response / no action) my review of
> > v4. This submission is therefore not getting one! All comments can be
> > superimposed from v4.
>
> s/v4/v5/

not sure what you are talking about. I dropped the PM wrappers and
added a new patch moving the driver to use OF match. There were no
other comments as far as I can tell. Did I miss a second mail with
more comments?

-- Sebastian

[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 833 bytes --]