From: "Ville Syrjälä" <ville.syrjala@linux.intel.com>
To: Keith Busch <kbusch@kernel.org>
Cc: Christoph Hellwig <hch@lst.de>,
linux-kernel@vger.kernel.org, linux-nvme@lists.infradead.org,
Chaitanya Kulkarni <kch@nvidia.com>,
Gerd Bayer <gbayer@linux.ibm.com>,
Sagi Grimberg <sagi@grimberg.me>, Jens Axboe <axboe@fb.com>
Subject: Re: [PATCH] nvme-pci: Switch back to sync probe to fix rootfs mount regression
Date: Tue, 24 Jan 2023 19:12:20 +0200 [thread overview]
Message-ID: <Y9ARdPA4vckTQ4GP@intel.com> (raw)
In-Reply-To: <Y8//roUT5byp59UP@kbusch-mbp.dhcp.thefacebook.com>
On Tue, Jan 24, 2023 at 08:56:30AM -0700, Keith Busch wrote:
> On Tue, Jan 24, 2023 at 02:41:34PM +0100, Christoph Hellwig wrote:
> > On Tue, Jan 24, 2023 at 10:47:59AM +0200, Ville Syrjälä wrote:
> > > On Tue, Jan 24, 2023 at 07:21:40AM +0100, Christoph Hellwig wrote:
> > > > Err, no. We're not going to randomly revert things. If you want
> > > > to be productive check the one liner Keith reported in reply to the
> > > > last report.
> > >
> > > No idea what that previous report is. Care to share a link?
> >
> > https://lore.kernel.org/linux-nvme/849c43bc-7488-72a6-f6fc-8700639b0c79@leemhuis.info/T/#m759092f541ea29fcb41911890307e70868636a45
> >
> > Patch to test:
> >
> > https://lore.kernel.org/linux-nvme/849c43bc-7488-72a6-f6fc-8700639b0c79@leemhuis.info/T/#md13c22b29cd81bd0ce9167c271c582005ba30550
>
> I'll post the official patch if someone can let me know if it's
> successful. Or I can potentially setup a VM to verify myself, but I
> probably won't be able to get to that till next week.
Appears to work here. I threw a tested-by to the original thread.
--
Ville Syrjälä
Intel
prev parent reply other threads:[~2023-01-24 17:12 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-01-24 0:45 [PATCH] nvme-pci: Switch back to sync probe to fix rootfs mount regression Ville Syrjala
2023-01-24 6:21 ` Christoph Hellwig
2023-01-24 8:47 ` Ville Syrjälä
2023-01-24 13:41 ` Christoph Hellwig
2023-01-24 15:56 ` Keith Busch
2023-01-24 17:12 ` Ville Syrjälä [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=Y9ARdPA4vckTQ4GP@intel.com \
--to=ville.syrjala@linux.intel.com \
--cc=axboe@fb.com \
--cc=gbayer@linux.ibm.com \
--cc=hch@lst.de \
--cc=kbusch@kernel.org \
--cc=kch@nvidia.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-nvme@lists.infradead.org \
--cc=sagi@grimberg.me \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox