Re: [PATCH v2] perf: cs-etm: Improve missing sink warning message

Suzuki K Poulose
2023-01-24T11:08:48Z

On 24/01/2023 11:02, James Clark wrote:
> Make the sink error message more similar to the event error message that
> reminds about missing kernel support. The available sinks are also
> determined by the hardware so mention that too.
>
> Also, usually it's not necessary to specify the sink, so add that as a
> hint.
>
> Now the error for a made up sink looks like this:
>
> $ perf record -e cs_etm/@abc/
> Couldn't find sink "abc" on event cs_etm/@abc/.
> Missing kernel or device support?
>
> Hint: An appropriate sink will be picked automatically if one isn't is specified.
>
> For any error other than ENOENT, the same message as before is
> displayed.
>
> Signed-off-by: James Clark <james.clark@arm.com>

Acked-by: Suzuki K Poulose <suzuki.poulose@arm.com>