From: Andy Shevchenko <andriy.shevchenko@intel.com>
To: "Martin Zaťovič" <m.zatovic1@gmail.com>
Cc: linux-kernel@vger.kernel.org, devicetree@vger.kernel.org,
mani@kernel.org, hemantk@codeaurora.org, quic_jhugo@quicinc.com,
andersson@kernel.org, Michael.Srba@seznam.cz, arnd@arndb.de,
dipenp@nvidia.com, bvanassche@acm.org, iwona.winiarska@intel.com,
ogabbay@kernel.org, tzimmermann@suse.de, fmdefrancesco@gmail.com,
jason.m.bills@linux.intel.com, jae.hyun.yoo@linux.intel.com,
gregkh@linuxfoundation.org, krzysztof.kozlowski+dt@linaro.org,
robh+dt@kernel.org
Subject: Re: [PATCH 3/3] wiegand: add Wiegand GPIO bit-banged controller driver
Date: Wed, 25 Jan 2023 13:49:10 +0200 [thread overview]
Message-ID: <Y9EXNmgMR1uHTgX4@smile.fi.intel.com> (raw)
In-Reply-To: <Y9D2V1dz6/+EOa5D@fedora>
On Wed, Jan 25, 2023 at 10:28:55AM +0100, Martin Zaťovič wrote:
> Hi Andy,
>
> thank you for the notes, I am working on fixing them. You have
> mentioned, that it seems like the driver which should be generic
> provides specific functionality. AFAIK, the Wiegand protocol
> does not define the payload length of messages. Most devices use
> one of the three formats I have implemented - 26, 36 and
> 37-bits. If I understand you right, the Wiegand GPIO bit-banged
> driver should allow one to send messages of any length and it
> will be up to a device driver to make sure the correct message
> length is used. Is this the correct approach?
Yes. But it's up to you to come with a final design. I don't
know your hardware nor protocol, so I might be mistaken. Hence,
try different approaches and look which one is better looking /
maintainable / etc.
--
With Best Regards,
Andy Shevchenko
prev parent reply other threads:[~2023-01-25 11:49 UTC|newest]
Thread overview: 22+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-01-04 13:34 [PATCH 0/3] Wiegand bus driver and GPIO controller driver Martin Zaťovič
2023-01-04 13:34 ` [PATCH 1/3] dt-bindings: add Wiegand controller dt-binding documentation Martin Zaťovič
2023-01-05 2:53 ` Rob Herring
2023-01-05 2:53 ` Rob Herring
2023-01-08 16:30 ` Rob Herring
2023-01-22 14:21 ` Krzysztof Kozlowski
2023-01-04 13:34 ` [PATCH 2/3] bus: add Wiegand bus driver Martin Zaťovič
2023-01-04 14:03 ` Greg KH
2023-01-04 14:05 ` Greg KH
2023-01-25 13:05 ` Martin Zaťovič
2023-01-25 13:16 ` Arnd Bergmann
2023-01-25 13:21 ` Martin Zaťovič
2023-01-25 13:26 ` Greg KH
2023-01-25 13:37 ` Martin Zaťovič
2023-01-04 14:06 ` Greg KH
2023-01-04 13:34 ` [PATCH 3/3] wiegand: add Wiegand GPIO bit-banged controller driver Martin Zaťovič
2023-01-04 14:05 ` Greg KH
2023-01-04 16:39 ` kernel test robot
2023-01-04 16:59 ` Andy Shevchenko
2023-01-04 17:01 ` Andy Shevchenko
2023-01-25 9:28 ` Martin Zaťovič
2023-01-25 11:49 ` Andy Shevchenko [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=Y9EXNmgMR1uHTgX4@smile.fi.intel.com \
--to=andriy.shevchenko@intel.com \
--cc=Michael.Srba@seznam.cz \
--cc=andersson@kernel.org \
--cc=arnd@arndb.de \
--cc=bvanassche@acm.org \
--cc=devicetree@vger.kernel.org \
--cc=dipenp@nvidia.com \
--cc=fmdefrancesco@gmail.com \
--cc=gregkh@linuxfoundation.org \
--cc=hemantk@codeaurora.org \
--cc=iwona.winiarska@intel.com \
--cc=jae.hyun.yoo@linux.intel.com \
--cc=jason.m.bills@linux.intel.com \
--cc=krzysztof.kozlowski+dt@linaro.org \
--cc=linux-kernel@vger.kernel.org \
--cc=m.zatovic1@gmail.com \
--cc=mani@kernel.org \
--cc=ogabbay@kernel.org \
--cc=quic_jhugo@quicinc.com \
--cc=robh+dt@kernel.org \
--cc=tzimmermann@suse.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox