From: Andy Shevchenko <andriy.shevchenko@linux.intel.com>
To: Hans de Goede <hdegoede@redhat.com>,
"Rafael J. Wysocki" <rafael.j.wysocki@intel.com>,
linux-acpi@vger.kernel.org, linux-kernel@vger.kernel.org,
acpica-devel@lists.linuxfoundation.org
Cc: "Rafael J. Wysocki" <rafael@kernel.org>,
Len Brown <lenb@kernel.org>,
Robert Moore <robert.moore@intel.com>
Subject: Re: [PATCH v1 2/3] ACPI: utils: Add acpi_get_first_match_physical_node()
Date: Wed, 25 Jan 2023 17:21:48 +0200 [thread overview]
Message-ID: <Y9FJDFgdLYN2hpl4@smile.fi.intel.com> (raw)
In-Reply-To: <20230123171006.58274-2-andriy.shevchenko@linux.intel.com>
On Mon, Jan 23, 2023 at 07:10:05PM +0200, Andy Shevchenko wrote:
> There are drivers that are using a logic that is combined in the offered
> acpi_get_first_match_physical_node(). The rationale to have this helper
> not only redunction of the lines of code, but improving the robustness
> by properly handling the reference counters on the error paths.
After rebasing on top of the latest code base (with Hans' patches included) I
checked the users of similar code flow and found that there is no sense to
provide this helper now. It's only one user for this API as is, otherwise it
needs an access to struct acpi_device, which the proposed API doesn't provide.
Hence, self-NAK.
--
With Best Regards,
Andy Shevchenko
next prev parent reply other threads:[~2023-01-25 15:21 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-01-23 17:10 [PATCH v1 1/3] ACPI: video: Fix refcounting in apple_gmux_backlight_present() Andy Shevchenko
2023-01-23 17:10 ` [PATCH v1 2/3] ACPI: utils: Add acpi_get_first_match_physical_node() Andy Shevchenko
2023-01-25 15:21 ` Andy Shevchenko [this message]
2023-01-23 17:10 ` [PATCH v1 3/3] ACPI: video: Switch to use acpi_get_first_match_physical_node() Andy Shevchenko
2023-01-23 17:46 ` [PATCH v1 1/3] ACPI: video: Fix refcounting in apple_gmux_backlight_present() Hans de Goede
2023-01-23 18:18 ` Andy Shevchenko
2023-01-23 19:24 ` Rafael J. Wysocki
2023-01-24 9:04 ` Andy Shevchenko
2023-01-23 22:10 ` Hans de Goede
2023-01-24 9:05 ` Andy Shevchenko
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=Y9FJDFgdLYN2hpl4@smile.fi.intel.com \
--to=andriy.shevchenko@linux.intel.com \
--cc=acpica-devel@lists.linuxfoundation.org \
--cc=hdegoede@redhat.com \
--cc=lenb@kernel.org \
--cc=linux-acpi@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=rafael.j.wysocki@intel.com \
--cc=rafael@kernel.org \
--cc=robert.moore@intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox