From: Andy Shevchenko <andriy.shevchenko@intel.com>
To: Bartosz Golaszewski <brgl@bgdev.pl>
Cc: Pierluigi Passaro <pierluigi.p@variscite.com>,
linus.walleij@linaro.org, yamada.masahiro@socionext.com,
linux-gpio@vger.kernel.org, linux-kernel@vger.kernel.org,
sfr@canb.auug.org.au, eran.m@variscite.com, nate.d@variscite.com,
francesco.f@variscite.com, pierluigi.passaro@gmail.com,
kernel test robot <lkp@intel.com>
Subject: Re: [PATCH v3] gpiolib: fix linker errors when GPIOLIB is disabled
Date: Wed, 25 Jan 2023 20:22:04 +0200 [thread overview]
Message-ID: <Y9FzTGxX5Z+XsTHV@smile.fi.intel.com> (raw)
In-Reply-To: <CAMRc=Mcf+PA-uhT+3Sq5AxHUMb-K_ogw=kBtGV6-wK00PtXGkw@mail.gmail.com>
On Tue, Jan 24, 2023 at 09:54:54AM +0100, Bartosz Golaszewski wrote:
> On Tue, Jan 24, 2023 at 2:31 AM Pierluigi Passaro
> <pierluigi.p@variscite.com> wrote:
...
> > #else /* CONFIG_GPIOLIB */
> >
> > +#include <linux/gpio/machine.h>
> > +#include <linux/gpio/consumer.h>
>
> Please move those headers to the top and arrange them alphabetically
> with the rest of the <linux/ headers. Since you're now including
> those, remove any forward declarations of the types in question.
That's not correct way. The headers will make the whole purpose of splitting
(between driver, machine, and consumer) useless.
Lemme look at it, but I believe the solution is not so simple.
We need to clean up header inclusions as we did for pin control.
--
With Best Regards,
Andy Shevchenko
next prev parent reply other threads:[~2023-01-25 18:22 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-01-24 1:31 [PATCH v3] gpiolib: fix linker errors when GPIOLIB is disabled Pierluigi Passaro
2023-01-24 8:54 ` Bartosz Golaszewski
2023-01-25 18:22 ` Andy Shevchenko [this message]
2023-01-25 18:59 ` Andy Shevchenko
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=Y9FzTGxX5Z+XsTHV@smile.fi.intel.com \
--to=andriy.shevchenko@intel.com \
--cc=brgl@bgdev.pl \
--cc=eran.m@variscite.com \
--cc=francesco.f@variscite.com \
--cc=linus.walleij@linaro.org \
--cc=linux-gpio@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=lkp@intel.com \
--cc=nate.d@variscite.com \
--cc=pierluigi.p@variscite.com \
--cc=pierluigi.passaro@gmail.com \
--cc=sfr@canb.auug.org.au \
--cc=yamada.masahiro@socionext.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox