From: Ingo Molnar <mingo@kernel.org>
To: Waiman Long <longman@redhat.com>
Cc: "Peter Zijlstra" <peterz@infradead.org>,
"Ingo Molnar" <mingo@redhat.com>, "Will Deacon" <will@kernel.org>,
"Boqun Feng" <boqun.feng@gmail.com>,
linux-kernel@vger.kernel.org, john.p.donnelly@oracle.com,
"Hillf Danton" <hdanton@sina.com>,
"Mukesh Ojha" <quic_mojha@quicinc.com>,
"Ting11 Wang 王婷" <wangting11@xiaomi.com>
Subject: Re: [PATCH v7 0/4] lockinig/rwsem: Fix rwsem bugs & enable true lock handoff
Date: Thu, 26 Jan 2023 13:46:22 +0100 [thread overview]
Message-ID: <Y9J2HkiyLDmGPWyn@gmail.com> (raw)
In-Reply-To: <20230126003628.365092-1-longman@redhat.com>
* Waiman Long <longman@redhat.com> wrote:
> v7:
> - Add a comment to down_read_non_owner() in patch 2.
> - Drop v6 patches 4 & 6 and simplify the direct rwsem lock handoff
> patch as suggested by PeterZ.
>
> v6:
> - Fix an error in patch 2 reported by kernel test robot.
>
> v5:
> - Drop patch 2 and replace it with 2 new patches disabling preemption on
> all reader functions and writer functions respectively. The other
> patches are adjusted accordingly.
>
> It turns out the current waiter optimistic spinning code does not work
> that well if we have RT tasks in the mix. This patch series include two
> different fixes to resolve those issues. The last 3 patches modify the
> handoff code to implement true lock handoff similar to that of mutex.
>
> Waiman Long (4):
> locking/rwsem: Prevent non-first waiter from spinning in down_write()
> slowpath
> locking/rwsem: Disable preemption at all down_read*() and up_read()
> code paths
> locking/rwsem: Disable preemption at all down_write*() and up_write()
> code paths
> locking/rwsem: Enable direct rwsem lock handoff
>
> kernel/locking/rwsem.c | 161 +++++++++++++++++++++++++++++------------
> 1 file changed, 115 insertions(+), 46 deletions(-)
So as a first step I've applied the first 3 patches to the locking tree,
which are arguably fixes.
Thanks,
Ingo
next prev parent reply other threads:[~2023-01-26 12:46 UTC|newest]
Thread overview: 17+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-01-26 0:36 [PATCH v7 0/4] lockinig/rwsem: Fix rwsem bugs & enable true lock handoff Waiman Long
2023-01-26 0:36 ` [PATCH v7 1/4] locking/rwsem: Prevent non-first waiter from spinning in down_write() slowpath Waiman Long
2023-01-26 11:38 ` [tip: locking/core] " tip-bot2 for Waiman Long
2023-01-26 0:36 ` [PATCH v7 2/4] locking/rwsem: Disable preemption at all down_read*() and up_read() code paths Waiman Long
2023-01-26 11:38 ` [tip: locking/core] locking/rwsem: Disable preemption in " tip-bot2 for Waiman Long
2023-01-26 0:36 ` [PATCH v7 3/4] locking/rwsem: Disable preemption at all down_write*() and up_write() " Waiman Long
2023-01-26 11:38 ` [tip: locking/core] locking/rwsem: Disable preemption in " tip-bot2 for Waiman Long
2023-01-26 0:36 ` [PATCH v7 4/4] locking/rwsem: Enable direct rwsem lock handoff Waiman Long
2023-02-12 13:33 ` kernel test robot
2023-02-13 12:31 ` Peter Zijlstra
2023-02-13 17:14 ` Waiman Long
2023-02-13 21:52 ` Peter Zijlstra
2023-02-14 2:03 ` Waiman Long
2023-02-23 1:44 ` kernel test robot
2023-01-26 12:46 ` Ingo Molnar [this message]
2023-01-26 13:17 ` [PATCH v7 0/4] lockinig/rwsem: Fix rwsem bugs & enable true " Waiman Long
[not found] ` <20230126100441.4823-1-hdanton@sina.com>
2023-01-26 12:59 ` [PATCH v7 4/4] locking/rwsem: Enable direct rwsem " Waiman Long
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=Y9J2HkiyLDmGPWyn@gmail.com \
--to=mingo@kernel.org \
--cc=boqun.feng@gmail.com \
--cc=hdanton@sina.com \
--cc=john.p.donnelly@oracle.com \
--cc=linux-kernel@vger.kernel.org \
--cc=longman@redhat.com \
--cc=mingo@redhat.com \
--cc=peterz@infradead.org \
--cc=quic_mojha@quicinc.com \
--cc=wangting11@xiaomi.com \
--cc=will@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox