From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id 55418C54EAA for ; Thu, 26 Jan 2023 10:17:49 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S236482AbjAZKRr (ORCPT ); Thu, 26 Jan 2023 05:17:47 -0500 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:40570 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S237062AbjAZKRj (ORCPT ); Thu, 26 Jan 2023 05:17:39 -0500 Received: from mga09.intel.com (mga09.intel.com [134.134.136.24]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 87E2F14491; Thu, 26 Jan 2023 02:17:12 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=intel.com; i=@intel.com; q=dns/txt; s=Intel; t=1674728232; x=1706264232; h=date:from:to:cc:subject:message-id:references: mime-version:in-reply-to; bh=6/mVui7KHyg/685hFsXA62gG5MkPwHTsQ8fsOw6kk7o=; b=j58poB+wqVja46qdWNa/H9DDea6SyONu+oXNC262PPzYpehoYZPpDNgg dUuqEcpytvzmL3y8XxxwDrGcT2VSfPhHg6abaK7XRd2ACQWuFji3igkUz IGsJMCaIvxZuPuvOdLiaPDQvokCZxQI5agoQtgRgpvkwQESyea2Qtf8WH HS2hSqb55w97rAnOVgEqS9ca7CdZflIp+Ei/9E585uTaoxubmhevwpU+E ZR8xnDhFHnNi1MqUIBBOpjDaBq1LHy65XO8nBhoWaCAzIhu5NVdWMPlPU ER86munb+p5tbQItq6KyKNjN/xk3GSZo7VNrzkbGl7Z80K1zSMmNUj5TE A==; X-IronPort-AV: E=McAfee;i="6500,9779,10601"; a="328029234" X-IronPort-AV: E=Sophos;i="5.97,248,1669104000"; d="scan'208";a="328029234" Received: from fmsmga008.fm.intel.com ([10.253.24.58]) by orsmga102.jf.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 26 Jan 2023 02:16:20 -0800 X-ExtLoop1: 1 X-IronPort-AV: E=McAfee;i="6500,9779,10601"; a="726223665" X-IronPort-AV: E=Sophos;i="5.97,248,1669104000"; d="scan'208";a="726223665" Received: from smile.fi.intel.com ([10.237.72.54]) by fmsmga008.fm.intel.com with ESMTP; 26 Jan 2023 02:16:18 -0800 Received: from andy by smile.fi.intel.com with local (Exim 4.96) (envelope-from ) id 1pKzIm-00FKtE-0t; Thu, 26 Jan 2023 12:16:16 +0200 Date: Thu, 26 Jan 2023 12:16:16 +0200 From: Andy Shevchenko To: Arnd Bergmann Cc: Bartosz Golaszewski , Christophe Leroy , Dmitry Torokhov , "open list:GPIO SUBSYSTEM" , Linux-Arch , linux-kernel@vger.kernel.org, Linus Walleij , Bartosz Golaszewski Subject: Re: [PATCH v1 5/5] gpio: Clean up headers Message-ID: References: <20230125201020.10948-1-andriy.shevchenko@linux.intel.com> <20230125201020.10948-6-andriy.shevchenko@linux.intel.com> <8454db45-a967-4542-8f16-538043542e14@app.fastmail.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <8454db45-a967-4542-8f16-538043542e14@app.fastmail.com> Organization: Intel Finland Oy - BIC 0357606-4 - Westendinkatu 7, 02160 Espoo Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Thu, Jan 26, 2023 at 09:42:32AM +0100, Arnd Bergmann wrote: > On Wed, Jan 25, 2023, at 21:10, Andy Shevchenko wrote: > > There is a few things done: > > - include only the headers we are direct user of > > - when pointer is in use, provide a forward declaration > > - add missing headers > > - group generic headers and subsystem headers > > - sort each group alphabetically > > > > Signed-off-by: Andy Shevchenko > > --- > > include/asm-generic/gpio.h | 8 -------- > > include/linux/gpio.h | 9 +++------ > > include/linux/gpio/consumer.h | 14 ++++++++++---- > > include/linux/gpio/driver.h | 34 ++++++++++++++++++++++++---------- > > 4 files changed, 37 insertions(+), 28 deletions(-) > > This change looks fine, but it conflicts with a slightly > broader cleanup that I meant to have already submitted, > folding include/asm-generic/gpio.h into linux/gpio.h and > removing the driver-side interface from that. > > Let me try to dig out my series again, we should be able to > either use my version, or merge parts of this patch into it. Can you share your patches, so I will rebase mine on top and see what's left? -- With Best Regards, Andy Shevchenko