From: Andy Shevchenko <andriy.shevchenko@linux.intel.com>
To: Linus Walleij <linus.walleij@linaro.org>
Cc: Bartosz Golaszewski <bartosz.golaszewski@linaro.org>,
Christophe Leroy <christophe.leroy@csgroup.eu>,
Dmitry Torokhov <dmitry.torokhov@gmail.com>,
linux-gpio@vger.kernel.org, linux-arch@vger.kernel.org,
linux-kernel@vger.kernel.org, Bartosz Golaszewski <brgl@bgdev.pl>,
Arnd Bergmann <arnd@arndb.de>
Subject: Re: [PATCH v1 5/5] gpio: Clean up headers
Date: Thu, 26 Jan 2023 14:16:09 +0200 [thread overview]
Message-ID: <Y9JvCQSi3DB/6un3@smile.fi.intel.com> (raw)
In-Reply-To: <CACRpkdZ1g9BEb28-YzAU8V5geiYzT9drjT3EMxok70ex3fOCKA@mail.gmail.com>
On Thu, Jan 26, 2023 at 11:22:00AM +0100, Linus Walleij wrote:
> On Wed, Jan 25, 2023 at 9:10 PM Andy Shevchenko
> <andriy.shevchenko@linux.intel.com> wrote:
>
> > There is a few things done:
> > - include only the headers we are direct user of
> > - when pointer is in use, provide a forward declaration
> > - add missing headers
> > - group generic headers and subsystem headers
> > - sort each group alphabetically
> >
> > Signed-off-by: Andy Shevchenko <andriy.shevchenko@linux.intel.com>
>
> Just to add to the confusion I was also pursuing a series of cleanups directed
> at just removing <linux/gpio/driver.h> from <linux/gpio.h>:
> https://lore.kernel.org/linux-gpio/CACRpkdb6yMqTkrJOg+K46RZ1478-gbxh6=tw4bzWmd--5nj_Bw@mail.gmail.com/
>
> Right now I don't know what to do :D
I saw your series and find them very good!
Can we have them applied?
Arnd's one probably also needs to be considered sooner.
This one can be postponed.
--
With Best Regards,
Andy Shevchenko
next prev parent reply other threads:[~2023-01-26 12:16 UTC|newest]
Thread overview: 23+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-01-25 20:10 [PATCH v1 0/5] gpio: First attempt to clean up headers Andy Shevchenko
2023-01-25 20:10 ` [PATCH v1 1/5] gpiolib: fix linker errors when GPIOLIB is disabled Andy Shevchenko
2023-01-26 8:14 ` Christophe Leroy
2023-01-26 8:40 ` Arnd Bergmann
2023-01-26 10:17 ` Andy Shevchenko
2023-01-26 10:27 ` Arnd Bergmann
2023-01-26 12:14 ` Andy Shevchenko
2023-01-26 10:19 ` Andy Shevchenko
2023-01-26 12:44 ` Christophe Leroy
2023-01-26 12:56 ` Arnd Bergmann
2023-01-26 13:29 ` Andy Shevchenko
2023-01-26 13:41 ` Pierluigi Passaro
2023-01-26 14:10 ` Arnd Bergmann
2023-01-25 20:10 ` [PATCH v1 2/5] gpio: Drop unused forward declaration from driver.h Andy Shevchenko
2023-01-25 20:10 ` [PATCH v1 3/5] gpio: Deduplicate forward declarations in consumer.h Andy Shevchenko
2023-01-25 20:10 ` [PATCH v1 4/5] gpio: Group " Andy Shevchenko
2023-01-25 20:10 ` [PATCH v1 5/5] gpio: Clean up headers Andy Shevchenko
2023-01-26 8:42 ` Arnd Bergmann
2023-01-26 10:16 ` Andy Shevchenko
2023-01-26 13:08 ` Arnd Bergmann
2023-01-26 10:22 ` Linus Walleij
2023-01-26 12:16 ` Andy Shevchenko [this message]
2023-01-26 12:29 ` Linus Walleij
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=Y9JvCQSi3DB/6un3@smile.fi.intel.com \
--to=andriy.shevchenko@linux.intel.com \
--cc=arnd@arndb.de \
--cc=bartosz.golaszewski@linaro.org \
--cc=brgl@bgdev.pl \
--cc=christophe.leroy@csgroup.eu \
--cc=dmitry.torokhov@gmail.com \
--cc=linus.walleij@linaro.org \
--cc=linux-arch@vger.kernel.org \
--cc=linux-gpio@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox