From: Peter Zijlstra <peterz@infradead.org>
To: Roman Kagan <rkagan@amazon.de>,
Zhang Qiao <zhangqiao22@huawei.com>,
Waiman Long <longman@redhat.com>, Ingo Molnar <mingo@redhat.com>,
Juri Lelli <juri.lelli@redhat.com>,
Vincent Guittot <vincent.guittot@linaro.org>,
Dietmar Eggemann <dietmar.eggemann@arm.com>,
Steven Rostedt <rostedt@goodmis.org>,
Ben Segall <bsegall@google.com>, Mel Gorman <mgorman@suse.de>,
Daniel Bristot de Oliveira <bristot@redhat.com>,
lkml <linux-kernel@vger.kernel.org>
Subject: Re: [bug-report] possible s64 overflow in max_vruntime()
Date: Fri, 27 Jan 2023 12:44:23 +0100 [thread overview]
Message-ID: <Y9O5Fwfib2CVAMwl@hirez.programming.kicks-ass.net> (raw)
In-Reply-To: <Y9LG5vkf/4ufJb35@u40bc5e070a0153.ant.amazon.com>
On Thu, Jan 26, 2023 at 07:31:02PM +0100, Roman Kagan wrote:
> > All that only matters for small sleeps anyway.
> >
> > Something like:
> >
> > sleep_time = U64_MAX;
> > if (se->avg.last_update_time)
> > sleep_time = cfs_rq_clock_pelt(cfs_rq) - se->avg.last_update_time;
>
> Interesting, why not rq_clock_task(rq_of(cfs_rq)) - se->exec_start, as
> others were suggesting? It appears to better match the notion of sleep
> wall-time, no?
Should also work I suppose. cfs_rq_clock takes throttling into account,
but that should hopefully also not be *that* long, so either should
work.
next prev parent reply other threads:[~2023-01-27 13:02 UTC|newest]
Thread overview: 24+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-12-21 15:19 [bug-report] possible s64 overflow in max_vruntime() Zhang Qiao
2022-12-21 16:10 ` Waiman Long
2022-12-22 12:45 ` Peter Zijlstra
2022-12-23 13:57 ` Zhang Qiao
2023-01-12 3:01 ` Zhang Qiao
2023-01-25 19:57 ` Roman Kagan
2023-01-25 19:45 ` Roman Kagan
2023-01-26 12:49 ` Peter Zijlstra
2023-01-26 18:31 ` Roman Kagan
2023-01-27 11:44 ` Peter Zijlstra [this message]
2023-01-27 16:18 ` Vincent Guittot
2023-01-27 22:10 ` Benjamin Segall
2023-01-27 22:29 ` Vincent Guittot
2023-01-31 3:21 ` Chen Yu
2023-01-31 9:59 ` Roman Kagan
2023-01-31 11:10 ` Vincent Guittot
2023-02-01 12:52 ` Chen Yu
2023-02-07 19:37 ` Roman Kagan
2023-02-08 10:13 ` Vincent Guittot
2023-02-08 18:09 ` Roman Kagan
2023-02-09 11:26 ` Vincent Guittot
2023-02-09 13:33 ` Roman Kagan
2023-02-09 13:44 ` Vincent Guittot
2023-02-09 14:34 ` Roman Kagan
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=Y9O5Fwfib2CVAMwl@hirez.programming.kicks-ass.net \
--to=peterz@infradead.org \
--cc=bristot@redhat.com \
--cc=bsegall@google.com \
--cc=dietmar.eggemann@arm.com \
--cc=juri.lelli@redhat.com \
--cc=linux-kernel@vger.kernel.org \
--cc=longman@redhat.com \
--cc=mgorman@suse.de \
--cc=mingo@redhat.com \
--cc=rkagan@amazon.de \
--cc=rostedt@goodmis.org \
--cc=vincent.guittot@linaro.org \
--cc=zhangqiao22@huawei.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox