Re: [PATCH v2 06/11] driver core: fw_devlink: Allow marking a fwnode link as being part of a cycle

Andy Shevchenko
2023-01-30T12:12:16Z

On Fri, Jan 27, 2023 at 11:34:19PM -0800, Saravana Kannan wrote:
> On Fri, Jan 27, 2023 at 1:33 AM Andy Shevchenko
> <andriy.shevchenko@linux.intel.com> wrote:
> > On Thu, Jan 26, 2023 at 04:11:33PM -0800, Saravana Kannan wrote:

...

> > > - if (dev->fwnode && !list_empty(&dev->fwnode->suppliers) &&
> > > - !fw_devlink_is_permissive()) {
> > > - sup_fw = list_first_entry(&dev->fwnode->suppliers,
> > > - struct fwnode_link,
> > > - c_hook)->supplier;
> > > + sup_fw = fwnode_links_check_suppliers(dev->fwnode);
> >
> > dev_fwnode() ?
> >
> > ...
> >
> > > - val = !list_empty(&dev->fwnode->suppliers);
> > > + mutex_lock(&fwnode_link_lock);
> > > + val = !!fwnode_links_check_suppliers(dev->fwnode);
> >
> > Ditto?
>
> Similar response as Patch 1 and Patch 4.

Same.

--
With Best Regards,
Andy Shevchenko